<div dir="ltr">test?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 3, 2017 at 5:40 PM Bob Haarman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: inglorion<br class="gmail_msg">
Date: Fri Feb  3 19:28:44 2017<br class="gmail_msg">
New Revision: 294079<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=294079&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=294079&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
fix nullptr Mangler in LTOModule<br class="gmail_msg">
<br class="gmail_msg">
Reviewers: kcc, pcc<br class="gmail_msg">
<br class="gmail_msg">
Subscribers: mehdi_amini<br class="gmail_msg">
<br class="gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D29523" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29523</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/lib/LTO/LTOModule.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/LTO/LTOModule.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOModule.cpp?rev=294079&r1=294078&r2=294079&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOModule.cpp?rev=294079&r1=294078&r2=294079&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/LTO/LTOModule.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/LTO/LTOModule.cpp Fri Feb  3 19:28:44 2017<br class="gmail_msg">
@@ -16,6 +16,7 @@<br class="gmail_msg">
 #include "llvm/ADT/Triple.h"<br class="gmail_msg">
 #include "llvm/Bitcode/BitcodeReader.h"<br class="gmail_msg">
 #include "llvm/CodeGen/Analysis.h"<br class="gmail_msg">
+#include "llvm/CodeGen/TargetLoweringObjectFileImpl.h"<br class="gmail_msg">
 #include "llvm/IR/Constants.h"<br class="gmail_msg">
 #include "llvm/IR/DiagnosticPrinter.h"<br class="gmail_msg">
 #include "llvm/IR/LLVMContext.h"<br class="gmail_msg">
@@ -647,11 +648,15 @@ void LTOModule::parseMetadata() {<br class="gmail_msg">
     }<br class="gmail_msg">
   }<br class="gmail_msg">
<br class="gmail_msg">
-  // Globals<br class="gmail_msg">
+  // Globals - we only need to do this for COFF.<br class="gmail_msg">
+  const Triple TT(_target->getTargetTriple());<br class="gmail_msg">
+  if (!TT.isOSBinFormatCOFF())<br class="gmail_msg">
+    return;<br class="gmail_msg">
+  Mangler M;<br class="gmail_msg">
   for (const NameAndAttributes &Sym : _symbols) {<br class="gmail_msg">
     if (!Sym.symbol)<br class="gmail_msg">
       continue;<br class="gmail_msg">
-    _target->getObjFileLowering()->emitLinkerFlagsForGlobal(OS, Sym.symbol);<br class="gmail_msg">
+    emitLinkerFlagsForGlobalCOFF(OS, Sym.symbol, TT, M);<br class="gmail_msg">
   }<br class="gmail_msg">
<br class="gmail_msg">
   // Add other interesting metadata here.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>