<div dir="ltr">This patch breaks compiler-rt tests <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/801/steps/test%20standalone%20compiler-rt/logs/stdio">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/801/steps/test%20standalone%20compiler-rt/logs/stdio</a></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Feb 6, 2017 at 8:18 AM Kostya Kortchinsky via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Jonas, feel free to LGTM it to speed up the process :)</div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Mon, Feb 6, 2017 at 7:20 AM, Kostya Kortchinsky <span dir="ltr" class="gmail_msg"><<a href="mailto:kostyak@google.com" class="gmail_msg" target="_blank">kostyak@google.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Hi,<div class="gmail_msg"><br class="gmail_msg"><a href="https://reviews.llvm.org/D29527" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29527</a> is out for review to fix this.<span class="m_5508933356210100186HOEnZb gmail_msg"><font color="#888888" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Kostya</div></font></span></div></div><div class="m_5508933356210100186HOEnZb gmail_msg"><div class="m_5508933356210100186h5 gmail_msg"><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Mon, Feb 6, 2017 at 1:18 AM, Hahnfeld, Jonas <span dir="ltr" class="gmail_msg"><<a href="mailto:Hahnfeld@itc.rwth-aachen.de" class="gmail_msg" target="_blank">Hahnfeld@itc.rwth-aachen.de</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br class="gmail_msg">
<div class="gmail_msg"><div class="m_5508933356210100186m_-9011879123930178650h5 gmail_msg"><br class="gmail_msg">
> -----Original Message-----<br class="gmail_msg">
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On Behalf<br class="gmail_msg">
> Of Kostya Kortchinsky via llvm-commits<br class="gmail_msg">
> Sent: Friday, February 03, 2017 9:50 PM<br class="gmail_msg">
> To: <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
> Subject: [compiler-rt] r294037 - [scudo] 32-bit quarantine sizes adjustments<br class="gmail_msg">
> and bug fixes<br class="gmail_msg">
><br class="gmail_msg">
> Author: cryptoad<br class="gmail_msg">
> Date: Fri Feb 3 14:49:42 2017<br class="gmail_msg">
> New Revision: 294037<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=294037&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=294037&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> [scudo] 32-bit quarantine sizes adjustments and bug fixes<br class="gmail_msg">
><br class="gmail_msg">
> Summary:<br class="gmail_msg">
> The local and global quarantine sizes were not offering a distinction for<br class="gmail_msg">
> 32-bit<br class="gmail_msg">
> and 64-bit platforms. This is addressed with lower values for 32-bit.<br class="gmail_msg">
><br class="gmail_msg">
> When writing additional tests for the quarantine, it was discovered that<br class="gmail_msg">
> when calling some of the allocator interface function prior to any<br class="gmail_msg">
> allocation<br class="gmail_msg">
> operation having occured, the test would crash due to the allocator not<br class="gmail_msg">
> being<br class="gmail_msg">
> initialized. This was addressed by making sure the allocator is initialized<br class="gmail_msg">
> for<br class="gmail_msg">
> those scenarios.<br class="gmail_msg">
><br class="gmail_msg">
> Relevant tests were added in interface.cpp and quarantine.cpp.<br class="gmail_msg">
><br class="gmail_msg">
> Last change being the removal of the extraneous link dependencies for the<br class="gmail_msg">
> tests thanks to rL293220, anf the addition of the gc-sections linker flag.<br class="gmail_msg">
><br class="gmail_msg">
> Reviewers: kcc, alekseyshl<br class="gmail_msg">
><br class="gmail_msg">
> Reviewed By: alekseyshl<br class="gmail_msg">
><br class="gmail_msg">
> Subscribers: llvm-commits<br class="gmail_msg">
><br class="gmail_msg">
> Differential Revision: <a href="https://reviews.llvm.org/D29341" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29341</a><br class="gmail_msg">
><br class="gmail_msg">
> Modified:<br class="gmail_msg">
> compiler-rt/trunk/lib/scudo/scudo_allocator.cpp<br class="gmail_msg">
> compiler-rt/trunk/lib/scudo/scudo_flags.cpp<br class="gmail_msg">
> compiler-rt/trunk/lib/scudo/scudo_flags.inc<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/alignment.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/double-free.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/interface.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/lit.cfg<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/malloc.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/memalign.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/mismatch.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/options.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/overflow.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/preinit.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/quarantine.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/realloc.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/secondary.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/sized-delete.cpp<br class="gmail_msg">
> compiler-rt/trunk/test/scudo/sizes.cpp<br class="gmail_msg">
><br class="gmail_msg">
</div></div>> [...]<br class="gmail_msg">
><br class="gmail_msg">
> Modified: compiler-rt/trunk/test/scudo/lit.cfg<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-</a><br class="gmail_msg">
> rt/trunk/test/scudo/lit.cfg?rev=294037&r1=294036&r2=294037&view=diff<br class="gmail_msg">
> ==========================================================<br class="gmail_msg">
<span class="gmail_msg">> ====================<br class="gmail_msg">
> --- compiler-rt/trunk/test/scudo/lit.cfg (original)<br class="gmail_msg">
> +++ compiler-rt/trunk/test/scudo/lit.cfg Fri Feb 3 14:49:42 2017<br class="gmail_msg">
> @@ -19,12 +19,12 @@ config.suffixes = ['.c', '.cc', '.cpp']<br class="gmail_msg">
> # C flags.<br class="gmail_msg">
> c_flags = ([config.target_cflags] +<br class="gmail_msg">
> ["-std=c++11",<br class="gmail_msg">
> - "-lrt",<br class="gmail_msg">
> - "-ldl",<br class="gmail_msg">
<br class="gmail_msg">
</span>With this change, I'm getting link errors for dlsym, shm_open and shm_unlink.<br class="gmail_msg">
Can we read these libraries?<br class="gmail_msg">
<br class="gmail_msg">
Thanks,<br class="gmail_msg">
Jonas<br class="gmail_msg">
</blockquote></div><br class="gmail_msg"></div>
</div></div></blockquote></div><br class="gmail_msg"></div>
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>