<div dir="ltr">On Mon, Feb 6, 2017 at 7:38 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Mon, Feb 6, 2017 at 2:24 PM, Bob Haarman via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">inglorion added inline comments.<br>
<br>
<br>
================<br>
Comment at: COFF/Writer.cpp:307<br>
<span>+    createPDB(Config->PDBPath, Symtab, SectionTable, BuildId->DI);<br>
<br>
   if (auto EC = Buffer->commit())<br>
     fatal(EC, "failed to write the output file");<br>
</span>----------------<br>
This is causing the linker to crash for me, because BuildId is nullptr. @compnerd, does that suggest a problem and a fix, or shall I do some more digging and cook up a patch?</blockquote><div><br></div></span><div>Thats an oversight on my part.  That implies that no debug info was generated, which means that BuildId will be a nullptr.  Ill try to fix this soon; thanks for pointing it out!</div></div></div></div></blockquote><div><br></div><div>SVN r294279</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail-m_-6988399848559837425HOEnZb"><div class="gmail-m_-6988399848559837425h5">
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D28182" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2818<wbr>2</a><br>
<br>
<br>
<br>
</div></div></blockquote></span></div><span class="gmail-HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_-6988399848559837425gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>