<div dir="ltr">It's a trivial change, I think. Good opportunity to 4.0 ;)</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Feb 1, 2017 at 7:56 AM Yichao Yu <<a href="mailto:yyc1992@gmail.com">yyc1992@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> It was suggested that this should be merged to 4.0. What do you think?<br class="gmail_msg">
<br class="gmail_msg">
Not an expert of the backport policy but this looks safe to me.<br class="gmail_msg">
<br class="gmail_msg">
><br class="gmail_msg">
> On Thu, Jan 26, 2017 at 3:50 PM, Yichao Yu via llvm-commits<br class="gmail_msg">
> <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
>> Author: yuyichao<br class="gmail_msg">
>> Date: Thu Jan 26 17:50:18 2017<br class="gmail_msg">
>> New Revision: 293230<br class="gmail_msg">
>><br class="gmail_msg">
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293230&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=293230&view=rev</a><br class="gmail_msg">
>> Log:<br class="gmail_msg">
>> CMake is funky on detecting Intel 17 as GCC compatible.<br class="gmail_msg">
>><br class="gmail_msg">
>> Summary: This adds a fallback in case that the Intel compiler is failed to be detected correctly.<br class="gmail_msg">
>><br class="gmail_msg">
>> Reviewers: chapuni<br class="gmail_msg">
>><br class="gmail_msg">
>> Reviewed By: chapuni<br class="gmail_msg">
>><br class="gmail_msg">
>> Subscribers: llvm-commits, mgorny<br class="gmail_msg">
>><br class="gmail_msg">
>> Differential Revision: <a href="https://reviews.llvm.org/D27610" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27610</a><br class="gmail_msg">
>><br class="gmail_msg">
>> Modified:<br class="gmail_msg">
>>     llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake<br class="gmail_msg">
>><br class="gmail_msg">
>> Modified: llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake<br class="gmail_msg">
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake?rev=293230&r1=293229&r2=293230&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake?rev=293230&r1=293229&r2=293230&view=diff</a><br class="gmail_msg">
>> ==============================================================================<br class="gmail_msg">
>> --- llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake (original)<br class="gmail_msg">
>> +++ llvm/trunk/cmake/modules/DetermineGCCCompatible.cmake Thu Jan 26 17:50:18 2017<br class="gmail_msg">
>> @@ -7,5 +7,7 @@ if(NOT DEFINED LLVM_COMPILER_IS_GCC_COMP<br class="gmail_msg">
>>      set(LLVM_COMPILER_IS_GCC_COMPATIBLE OFF)<br class="gmail_msg">
>>    elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" )<br class="gmail_msg">
>>      set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)<br class="gmail_msg">
>> +  elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "Intel" )<br class="gmail_msg">
>> +    set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)<br class="gmail_msg">
>>    endif()<br class="gmail_msg">
>>  endif()<br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>> _______________________________________________<br class="gmail_msg">
>> llvm-commits mailing list<br class="gmail_msg">
>> <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>