Assuming it's been lgtm'ed, it's not necessary to test on every platform before committing.  We can always revert if it breaks something.<br><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 30, 2017 at 4:38 PM Marcos Pividori via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">mpividori updated this revision to Diff 86365.<br class="gmail_msg">
mpividori added a comment.<br class="gmail_msg">
<br class="gmail_msg">
Done.<br class="gmail_msg">
@kubamracek could you test it on Darwin? should I submit the commit and see if buildbot fails?<br class="gmail_msg">
Thanks!<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D29148" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29148</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  lib/asan/asan_interface.inc<br class="gmail_msg">
  lib/asan/asan_interface_internal.h<br class="gmail_msg">
  lib/sanitizer_common/sanitizer_allocator_interface.h<br class="gmail_msg">
  lib/sanitizer_common/sanitizer_common_interface.inc<br class="gmail_msg">
  lib/sanitizer_common/sanitizer_common_interface_posix.inc<br class="gmail_msg">
  lib/sanitizer_common/sanitizer_coverage_interface.inc<br class="gmail_msg">
  lib/ubsan/ubsan_interface.inc<br class="gmail_msg">
  test/asan/TestCases/Darwin/interface_symbols_darwin.c<br class="gmail_msg">
  test/asan/TestCases/Linux/interface_symbols_linux.c<br class="gmail_msg">
  test/asan/TestCases/Windows/interface_symbols_windows.c<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>