<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 31 January 2017 at 14:59, Tamazov, Artem <span dir="ltr"><<a href="mailto:Artem.Tamazov@amd.com" target="_blank">Artem.Tamazov@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div lang="RU">
<div class="gmail-m_78518833525125031WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">Hello Alex,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">Oops, thanks for informing. This is my 2nd attempt to commit these tests, and it fails with sanitizers again(((<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">I definitely need to run these tests with sanitizers prior committing.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">These sanitizers are new for me, so I would appreciate if you let me know how can set up these tools locally.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">I have both Ubuntu and Windows machines on hand.</span></p></div></div></blockquote><div><br></div><div>Sure! I don't know about Windows, but I think Linux supports AddressSanitizer so it should be possible to reproduce the issue on Ubuntu. You can compile LLVM with AddressSanitizer enabled by passing in '-DLLVM_USE_SANITIZER=Address;' to cmake. Then when you run the test it should crash with a similar error reported by AddressSanitizer.</div><div><br></div><div>Alex</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div lang="RU"><div class="gmail-m_78518833525125031WordSection1"><p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">For now, I am going to revert tests, because triaging & fixing the issue in AMDGPU backed would take time.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">Regards,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">artem//<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:purple"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10pt;font-family:tahoma,sans-serif">From:</span></b><span lang="EN-US" style="font-size:10pt;font-family:tahoma,sans-serif"> Alex L [mailto:<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>]
<br>
<b>Sent:</b> 31 January 2017 г. 17:07<br>
<b>To:</b> Tamazov, Artem<br>
<b>Cc:</b> Alex Lorenz via llvm-commits<br>
<b>Subject:</b> Re: [llvm] r293552 - Reapply [AMDGPU][mc][tests][NFC] Add coverage/smoke tests for Gfx7 and Gfx8.<u></u><u></u></span></p><div><div class="gmail-h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hi Artem,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">The test "<span style="font-size:9.5pt">gfx7_asm_all.s" is failing because of a global-buffer-overflow AddressSanitizer error on our Asan+Ubsan bot at </span><a href="http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan/" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/clang-stage2-cmake-<wbr>RgSan/</a><span style="font-size:9.5pt">.
The output of the failing test that I obtained from </span><a href="http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2915/consoleFull" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/clang-stage2-cmake-<wbr>RgSan_check/2915/consoleFull</a><span style="font-size:9.5pt"> <wbr>is
shown below:</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Command Output (stderr):</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">--</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">==============================<wbr>==============================<wbr>=====</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">==32235==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00010e014f9b at pc 0x00010da57431 bp 0x7fff52d782b0 sp 0x7fff52d782a8</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">READ of size 1 at 0x00010e014f9b thread T0</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #0 0x10da57430 in llvm::AMDGPU::isSISrcOperand(<wbr>llvm::MCInstrDesc const&, unsigned int) AMDGPUBaseInfo.cpp:339</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #1 0x10d18e6bc in (anonymous namespace)::AMDGPUOperand::<wbr>addImmOperands(llvm::MCInst&, unsigned int, bool) const AMDGPUAsmParser.cpp:1111</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #2 0x10d191c8a in addOptionalImmOperand(llvm::<wbr>MCInst&, llvm::SmallVectorImpl<std::__<wbr>1::unique_ptr<llvm::<wbr>MCParsedAsmOperand, std::__1::default_delete<llvm:<wbr>:MCParsedAsmOperand> > > const&, std::__1::map<(anonymous
namespace)::AMDGPUOperand::<wbr>ImmTy, unsigned int, std::__1::less<(anonymous namespace)::AMDGPUOperand::<wbr>ImmTy>, std::__1::allocator<std::__1::<wbr>pair<(anonymous namespace)::AMDGPUOperand::<wbr>ImmTy const, unsigned int> > >&, (anonymous namespace)::AMDGPUOperand::<wbr>ImmTy,
long long) AMDGPUAsmParser.cpp:2295</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #3 0x10d185f84 in (anonymous namespace)::AMDGPUAsmParser::<wbr>convertToMCInst(unsigned int, llvm::MCInst&, unsigned int, llvm::SmallVectorImpl<std::__<wbr>1::unique_ptr<llvm::<wbr>MCParsedAsmOperand, std::__1::default_delete<llvm:<wbr>:MCParsedAsmOperand>
> > const&, llvm::SmallBitVector const&) AMDGPUAsmParser.cpp:2377</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #4 0x10d133d4b in (anonymous namespace)::AMDGPUAsmParser::<wbr>MatchAndEmitInstruction(llvm::<wbr>SMLoc, unsigned int&, llvm::SmallVectorImpl<std::__<wbr>1::unique_ptr<llvm::<wbr>MCParsedAsmOperand, std::__1::default_delete<llvm:<wbr>:MCParsedAsmOperand>
> >&, llvm::MCStreamer&, unsigned long long&, bool) AMDGPUGenAsmMatcher.inc:18466</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #5 0x10d8799e5 in (anonymous namespace)::AsmParser::<wbr>parseStatement((anonymous namespace)::<wbr>ParseStatementInfo&, llvm::MCAsmParserSemaCallback*<wbr>) AsmParser.cpp:2060</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #6 0x10d8631c5 in (anonymous namespace)::AsmParser::Run(<wbr>bool, bool) AsmParser.cpp:754</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #7 0x10ce85ec2 in main llvm-mc.cpp:437</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> #8 0x7fff93aba5ac in start (libdyld.dylib:x86_64+0x35ac)</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">0x00010e014f9b is located 37 bytes to the left of global variable 'llvm::OperandInfo72' defined in 'lib/Target/AMDGPU/<wbr>AMDGPUGenInstrInfo.inc:7522:<wbr>28' (0x10e014fc0) of size 40</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">0x00010e014f9b is located 3 bytes to the right of global variable 'llvm::OperandInfo71' defined in 'lib/Target/AMDGPU/<wbr>AMDGPUGenInstrInfo.inc:7521:<wbr>28' (0x10e014f80) of size 24</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">SUMMARY: AddressSanitizer: global-buffer-overflow AMDGPUBaseInfo.cpp:339 in llvm::AMDGPU::isSISrcOperand(<wbr>llvm::MCInstrDesc const&, unsigned int)</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Shadow bytes around the buggy address:</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c029a0: 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9 00 00 00 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c029b0: f9 f9 f9 f9 00 00 00 00 f9 f9 f9 f9 00 00 00 00</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c029c0: f9 f9 f9 f9 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c029d0: 00 00 00 00 00 00 f9 f9 f9 f9 f9 f9 00 00 00 00</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c029e0: 00 00 f9 f9 f9 f9 f9 f9 00 f9 f9 f9 f9 f9 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">=>0x100021c029f0: 00 00 00[f9]f9 f9 f9 f9 00 00 00 00 00 f9 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c02a00: f9 f9 f9 f9 00 00 00 00 00 f9 f9 f9 f9 f9 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c02a10: 00 00 00 00 f9 f9 f9 f9 00 00 00 00 00 00 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c02a20: f9 f9 f9 f9 00 00 00 00 00 00 f9 f9 f9 f9 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c02a30: 00 00 00 00 f9 f9 f9 f9 00 00 00 00 00 00 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> 0x100021c02a40: f9 f9 f9 f9 00 00 00 00 00 00 f9 f9 f9 f9 f9 f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Shadow byte legend (one shadow byte represents 8 application bytes):</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Addressable: 00</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Partially addressable: 01 02 03 04 05 06 07 </span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Heap left redzone: fa</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Freed heap region: fd</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Stack left redzone: f1</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Stack mid redzone: f2</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Stack right redzone: f3</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Stack after return: f5</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Stack use after scope: f8</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Global redzone: f9</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Global init order: f6</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Poisoned by user: f7</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Container overflow: fc</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Array cookie: ac</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Intra object redzone: bb</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> ASan internal: fe</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Left alloca redzone: ca</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> Right alloca redzone: cb</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">==32235==ABORTING</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Stack dump:</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US" style="font-size:9.5pt">0.<span class="gmail-m_78518833525125031gmail-apple-tab-span">
</span>Program arguments: </span><span style="font-size:9.5pt"><a href="mailto:/Users/buildslave/jenkins/sharedspace/clang-stage2-cmake-RgSan@2/clang-build/./bin/llvm-mc" target="_blank"><span lang="EN-US">/Users/buildslave/jenkins/<wbr>sharedspace/clang-stage2-<wbr>cmake-RgSan@2/clang-build/./<wbr>bin/llvm-mc</span></a></span><span lang="EN-US" style="font-size:9.5pt">
-arch=amdgcn -mcpu=bonaire -show-encoding </span><span style="font-size:9.5pt"><a href="mailto:/Users/buildslave/jenkins/sharedspace/clang-stage2-cmake-RgSan@2/llvm/test/MC/AMDGPU/gfx7_asm_all.s" target="_blank"><span lang="EN-US">/Users/buildslave/jenkins/<wbr>sharedspace/clang-stage2-<wbr>cmake-RgSan@2/llvm/test/MC/<wbr>AMDGPU/gfx7_asm_all.s</span></a></span><span lang="EN-US" style="font-size:9.5pt"> </span><span lang="EN-US"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><a href="mailto:/Users/buildslave/jenkins/sharedspace/clang-stage2-cmake-RgSan@2/llvm/test/MC/AMDGPU/gfx7_asm_all.s:1183:11" target="_blank"><span lang="EN-US">/Users/buildslave/jenkins/<wbr>sharedspace/clang-stage2-<wbr>cmake-RgSan@2/llvm/test/MC/<wbr>AMDGPU/gfx7_asm_all.s:1183:11</span></a></span><span lang="EN-US" style="font-size:9.5pt">:
error: expected string not found in input</span><span lang="EN-US"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">// CHECK: [0xff,0xff,0xfe,0xd8,0xff,<wbr>0x00,0x00,0x00]</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"> ^</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt"><stdin>:1182:1: note: scanning from here</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">^</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">--</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">********************</span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Can you please fix this issue? Let me know if you need anything else.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<div>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal">Alex<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 30 January 2017 at 21:59, Artem Tamazov via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: artem.tamazov<br>
Date: Mon Jan 30 15:59:21 2017<br>
New Revision: 293552<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293552&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project?rev=293552&view=rev</a><br>
Log:<br>
Reapply [AMDGPU][mc][tests][NFC] Add coverage/smoke tests for Gfx7 and Gfx8.<br>
<br>
Added:<br>
llvm/trunk/test/MC/AMDGPU/<wbr>gfx7_asm_all.s<br>
llvm/trunk/test/MC/AMDGPU/<wbr>gfx8_asm_all.s<br>
llvm/trunk/test/MC/<wbr>Disassembler/AMDGPU/gfx8_dasm_<wbr>all.txt<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div></div>