<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 27, 2017 at 1:00 PM, Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">My understanding is that they are supposed to stay the same and are duplicated only for licensing reason.</div></blockquote><div><br></div><div>/me horrified </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>— </div><span class="HOEnZb"><font color="#888888"><div>Mehdi</div></font></span><div><div class="h5"><div><br><div><br></div><div><br><div><blockquote type="cite"><div>On Jan 27, 2017, at 12:59 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:</div><br class="m_2541316641486547509Apple-interchange-newline"><div><div dir="ltr">Do we want to fuzz llvm/trunk/lib/Demangle/Itaniu<wbr>mDemangle.cpp in addition to <span style="font-size:12.8px">libcxxabi/trunk/src/cxa_</span><span style="font-size:12.8px">dem<wbr>angle.cpp? </span><div><span style="font-size:12.8px">Are we going to have both long term, or just one? <br></span><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 27, 2017 at 12:32 PM, Mehdi Amini via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: mehdi_amini<br>
Date: Fri Jan 27 14:32:16 2017<br>
New Revision: 293330<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293330&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=293330&view=rev</a><br>
Log:<br>
Fix ASAN failure in cxa_demangle<br>
<br>
Found with ASAN + libFuzzer by Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>><br>
<br>
Modified:<br>
    llvm/trunk/lib/Demangle/Itaniu<wbr>mDemangle.cpp<br>
<br>
Modified: llvm/trunk/lib/Demangle/Itaniu<wbr>mDemangle.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Demangle/ItaniumDemangle.cpp?rev=293330&r1=293329&r2=293330&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp?rev=<wbr>293330&r1=293329&r2=293330&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Demangle/Itaniu<wbr>mDemangle.cpp (original)<br>
+++ llvm/trunk/lib/Demangle/Itaniu<wbr>mDemangle.cpp Fri Jan 27 14:32:16 2017<br>
@@ -1402,7 +1402,8 @@ static const char *parse_function_type(c<br>
         int ref_qual = 0;<br>
         while (true) {<br>
           if (t == last) {<br>
-            db.names.pop_back();<br>
+            if (!db.names.empty())<br>
+              db.names.pop_back();<br>
             return first;<br>
           }<br>
           if (*t == 'E') {<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div>
</div></blockquote></div><br></div></div></div></div></div></blockquote></div><br></div></div>