<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 27, 2017, at 1:02 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" class="">kcc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Jan 27, 2017 at 1:00 PM, Mehdi Amini <span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">My understanding is that they are supposed to stay the same and are duplicated only for licensing reason.</div></blockquote><div class=""><br class=""></div><div class="">/me horrified </div></div></div></div></div></blockquote><div><br class=""></div><div>Yes :)</div><div><br class=""></div><div>The relicensing may solved this. The GitHub may help as well (by being able to share a top-level demangle project).</div><div><br class=""></div><div>In the meantime the version copied in LLVM can be targeted on the command line with llvm-cxxfilt.</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><div class="h5"><div class=""><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jan 27, 2017, at 12:59 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank" class="">kcc@google.com</a>> wrote:</div><br class="m_2541316641486547509Apple-interchange-newline"><div class=""><div dir="ltr" class="">Do we want to fuzz llvm/trunk/lib/Demangle/Itaniu<wbr class="">mDemangle.cpp in addition to <span style="font-size:12.8px" class="">libcxxabi/trunk/src/cxa_</span><span style="font-size:12.8px" class="">dem<wbr class="">angle.cpp? </span><div class=""><span style="font-size:12.8px" class="">Are we going to have both long term, or just one? <br class=""></span><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Jan 27, 2017 at 12:32 PM, Mehdi Amini via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: mehdi_amini<br class="">
Date: Fri Jan 27 14:32:16 2017<br class="">
New Revision: 293330<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293330&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject?rev=293330&view=rev</a><br class="">
Log:<br class="">
Fix ASAN failure in cxa_demangle<br class="">
<br class="">
Found with ASAN + libFuzzer by Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank" class="">kcc@google.com</a>><br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Demangle/Itaniu<wbr class="">mDemangle.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Demangle/Itaniu<wbr class="">mDemangle.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Demangle/ItaniumDemangle.cpp?rev=293330&r1=293329&r2=293330&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/llvm/trunk/lib/Demangle/<wbr class="">ItaniumDemangle.cpp?rev=<wbr class="">293330&r1=293329&r2=293330&<wbr class="">view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/Demangle/Itaniu<wbr class="">mDemangle.cpp (original)<br class="">
+++ llvm/trunk/lib/Demangle/Itaniu<wbr class="">mDemangle.cpp Fri Jan 27 14:32:16 2017<br class="">
@@ -1402,7 +1402,8 @@ static const char *parse_function_type(c<br class="">
int ref_qual = 0;<br class="">
while (true) {<br class="">
if (t == last) {<br class="">
- db.names.pop_back();<br class="">
+ if (!db.names.empty())<br class="">
+ db.names.pop_back();<br class="">
return first;<br class="">
}<br class="">
if (*t == 'E') {<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div></div></div>
</div></blockquote></div><br class=""></div></div></div></div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>