<div dir="ltr">Is it acceptable to reintroduce it for PPC only?</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 27, 2017 at 12:51 PM, Evgenii Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This breaks ppc:<br>
<a href="http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/1186/steps/check-asan%20in%20gcc%20build/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/sanitizer-ppc64le-<wbr>linux/builds/1186/steps/check-<wbr>asan%20in%20gcc%20build/logs/<wbr>stdio</a><br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Jan 26, 2017 at 2:50 PM, Kostya Kortchinsky via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: cryptoad<br>
> Date: Thu Jan 26 16:50:22 2017<br>
> New Revision: 293220<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293220&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=293220&view=rev</a><br>
> Log:<br>
> [sanitizer] Remove -fno-function-sections from SANITIZER_COMMON_CFLAGS<br>
><br>
> Summary:<br>
> -fno-function-sections was added as a default Sanitizer common cflag with<br>
> <a href="https://reviews.llvm.org/rL200683" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>rL200683</a>, the reasoning behind was that things would<br>
> break if linked with --gc-sections.<br>
><br>
> This appears to not be necessary anymore, as tests pass without, including<br>
> function-sections-are-bad.cc. There is a large benefit to having<br>
> function-sections when dealing with static libraries in terms of size and<br>
> dependencies that go away with --gc-sections.<br>
><br>
> Reviewers: kcc, eugenis<br>
><br>
> Reviewed By: eugenis<br>
><br>
> Subscribers: llvm-commits, mgorny<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D29132" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D29132</a><br>
><br>
> Modified:<br>
>     compiler-rt/trunk/CMakeLists.<wbr>txt<br>
><br>
> Modified: compiler-rt/trunk/CMakeLists.<wbr>txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=293220&r1=293219&r2=293220&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>CMakeLists.txt?rev=293220&r1=<wbr>293219&r2=293220&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- compiler-rt/trunk/CMakeLists.<wbr>txt (original)<br>
> +++ compiler-rt/trunk/CMakeLists.<wbr>txt Thu Jan 26 16:50:22 2017<br>
> @@ -142,7 +142,6 @@ append_list_if(COMPILER_RT_<wbr>HAS_FNO_STACK<br>
>  append_list_if(COMPILER_RT_<wbr>HAS_FNO_SANITIZE_SAFE_STACK_<wbr>FLAG -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS)<br>
>  append_list_if(COMPILER_RT_<wbr>HAS_FVISIBILITY_HIDDEN_FLAG -fvisibility=hidden SANITIZER_COMMON_CFLAGS)<br>
>  append_list_if(COMPILER_RT_<wbr>HAS_FVISIBILITY_INLINES_<wbr>HIDDEN_FLAG -fvisibility-inlines-hidden SANITIZER_COMMON_CFLAGS)<br>
> -append_list_if(COMPILER_RT_<wbr>HAS_FNO_FUNCTION_SECTIONS_FLAG -fno-function-sections SANITIZER_COMMON_CFLAGS)<br>
>  append_list_if(COMPILER_RT_<wbr>HAS_FNO_LTO_FLAG -fno-lto SANITIZER_COMMON_CFLAGS)<br>
><br>
>  if(MSVC)<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>