<p dir="ltr">Shrug. </p>
<br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 26, 2017, 11:06 AM Justin Lebar via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">jlebar added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: llvm/include/llvm/ADT/APFloat.h:24<br class="gmail_msg">
<br class="gmail_msg">
+#define APFLOAT_SINGLE_DISPATCH(METHOD_CALL)                                   \<br class="gmail_msg">
+  do {                                                                         \<br class="gmail_msg">
----------------<br class="gmail_msg">
timshen wrote:<br class="gmail_msg">
> echristo wrote:<br class="gmail_msg">
> > timshen wrote:<br class="gmail_msg">
> > > echristo wrote:<br class="gmail_msg">
> > > > timshen wrote:<br class="gmail_msg">
> > > > > jlebar wrote:<br class="gmail_msg">
> > > > > > echristo wrote:<br class="gmail_msg">
> > > > > > > jlebar wrote:<br class="gmail_msg">
> > > > > > > > What does "single" refer to here?<br class="gmail_msg">
> > > > > > > ><br class="gmail_msg">
> > > > > > > > APFLOAT_SEMANTIC_DISPATCH?  I don't really like that either.<br class="gmail_msg">
> > > > > > > ><br class="gmail_msg">
> > > > > > > > Maybe someone else has a better suggestion.<br class="gmail_msg">
> > > > > > > APFLOAT_FORMAT_DISPATCH ?<br class="gmail_msg">
> > > > > > I like that one.<br class="gmail_msg">
> > > > > For single dispatch, see <a href="https://en.m.wikipedia.org/wiki/Dynamic_dispatch#Single_and_multiple_dispatch" rel="noreferrer" class="gmail_msg" target="_blank">https://en.m.wikipedia.org/wiki/Dynamic_dispatch#Single_and_multiple_dispatch</a> .<br class="gmail_msg">
> > > > ><br class="gmail_msg">
> > > > > Here the macro expands to code that dispatches on "*this" APFloat object. This isn't the case for add or convert.<br class="gmail_msg">
> > > > Most people will read the macro as a "what are we doing" rather than "how are we doing it" I think which is why I suggested format.<br class="gmail_msg">
> > > I actually don't know what "format" means here. How about APFLOAT_DISPATCH? :)<br class="gmail_msg">
> > You could also use layout dispatch. The idea is the "format" of the float. I just don't like layout, but that's also fine if you'd prefer it.<br class="gmail_msg">
> I see. Some how "format" reminded me of format string... oh well.<br class="gmail_msg">
><br class="gmail_msg">
> Then the consistent term to use here is "semantics". How about APFLOAT_DISPATCH_ON_SEMANTICS?<br class="gmail_msg">
I'm also fine with that.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D29161" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29161</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>