<div dir="ltr">Hi Kostya,<br>Yes. I apologize, I made an error when rebasing. In r292735 I removed check-fuzzer dependency on TestBinaries. I will fix it.<br>Thanks,<br>Marcos</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 21, 2017 at 10:38 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">the libfuzzer bot became red. <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/sanitizer-x86_64-<wbr>linux-fuzzer</a><div>could you please check if one of your recent commits caused it? </div><div>Looks like some of the cmake changes broke all testing. </div><div><br></div><div>Thanks! </div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 21, 2017 at 6:28 PM, Marcos Pividori via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mpividori<br>
Date: Sat Jan 21 20:28:12 2017<br>
New Revision: 292749<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=292749&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=292749&view=rev</a><br>
Log:<br>
[libFuzzer] Specify the CRT considered (MT or MD) for tests on Windows.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D28439" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2843<wbr>9</a><br>
<br>
Modified:<br>
llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt<br>
<br>
Modified: llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/CMakeLists.txt?rev=292749&r1=292748&r2=292749&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Fuzzer/te<wbr>st/CMakeLists.txt?rev=292749&<wbr>r1=292748&r2=292749&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt (original)<br>
+++ llvm/trunk/lib/Fuzzer/test/CMa<wbr>keLists.txt Sat Jan 21 20:28:12 2017<br>
@@ -18,6 +18,13 @@ endforeach()<br>
set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=trace-pc-g<wbr>uard,indirect-calls,trace-cmp,<wbr>trace-div,trace-gep -gline-tables-only")<br>
<br>
if(MSVC)<br>
+ # For tests use the CRT specified for release build<br>
+ # (asan doesn't support MDd and MTd)<br>
+ if ("${LLVM_USE_CRT_RELEASE}" STREQUAL "")<br>
+ set(CRT_FLAG " /MD ")<br>
+ else()<br>
+ set(CRT_FLAG " /${LLVM_USE_CRT_RELEASE} ")<br>
+ endif()<br>
# In order to use the sanitizers in Windows, we need to link against many<br>
# runtime libraries which will depend on the target being created<br>
# (executable or dll) and the c runtime library used (MT/MD).<br>
@@ -28,8 +35,8 @@ if(MSVC)<br>
# the rules for linking executables and shared libraries, using the compiler<br>
# instead of link.exe. Clang will consider the sanitizer flags, and<br>
# automatically provide the required libraries to the linker.<br>
- set(CMAKE_CXX_LINK_EXECUTABLE "<CMAKE_CXX_COMPILER> <FLAGS> ${CMAKE_CXX_FLAGS} <OBJECTS> -o <TARGET> <LINK_LIBRARIES> /link <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS>")<br>
- set(CMAKE_CXX_CREATE_SHARED_LI<wbr>BRARY "<CMAKE_CXX_COMPILER> ${CMAKE_CXX_FLAGS} /LD <CMAKE_SHARED_LIBRARY_CXX_FLAG<wbr>S> <CMAKE_SHARED_LIBRARY_CREATE_C<wbr>XX_FLAGS> <CMAKE_SHARED_LIBRARY_SONAME_C<wbr>XX_FLAG> <TARGET_SONAME> -o <TARGET> <OBJECTS> <LINK_LIBRARIES> /link <LINK_FLAGS>")<br>
+ set(CMAKE_CXX_LINK_EXECUTABLE "<CMAKE_CXX_COMPILER> <FLAGS> ${CMAKE_CXX_FLAGS} ${CRT_FLAG} <OBJECTS> -o <TARGET> <LINK_LIBRARIES> /link <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS>")<br>
+ set(CMAKE_CXX_CREATE_SHARED_LI<wbr>BRARY "<CMAKE_CXX_COMPILER> ${CMAKE_CXX_FLAGS} ${CRT_FLAG} /LD <CMAKE_SHARED_LIBRARY_CXX_FLAG<wbr>S> <CMAKE_SHARED_LIBRARY_CREATE_C<wbr>XX_FLAGS> <CMAKE_SHARED_LIBRARY_SONAME_C<wbr>XX_FLAG> <TARGET_SONAME> -o <TARGET> <OBJECTS> <LINK_LIBRARIES> /link <LINK_FLAGS>")<br>
endif()<br>
<br>
# add_libfuzzer_test(<name><br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>