<div dir="ltr">Thank you!<div>Sorry, somehow I missed that a host compiler can be something else.</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 18, 2017 at 11:18 AM Justin Bogner <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Vitaly Buka via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> writes:<br class="gmail_msg">
> Author: vitalybuka<br class="gmail_msg">
> Date: Tue Jan 17 15:04:23 2017<br class="gmail_msg">
> New Revision: 292256<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=292256&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=292256&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> Enabled -fsanitize-address-use-after-scope for -DLLVM_USE_SANITIZER=Address<br class="gmail_msg">
><br class="gmail_msg">
> Subscribers: mgorny, llvm-commits<br class="gmail_msg">
><br class="gmail_msg">
> Differential Revision: <a href="https://reviews.llvm.org/D28823" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28823</a><br class="gmail_msg">
><br class="gmail_msg">
> Modified:<br class="gmail_msg">
>     llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br class="gmail_msg">
><br class="gmail_msg">
> Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br class="gmail_msg">
> URL:<br class="gmail_msg">
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=292256&r1=292255&r2=292256&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=292256&r1=292255&r2=292256&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
><br class="gmail_msg">
> --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)<br class="gmail_msg">
> +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Tue Jan 17 15:04:23 2017<br class="gmail_msg">
> @@ -588,6 +588,9 @@ if(LLVM_USE_SANITIZER)<br class="gmail_msg">
>    else()<br class="gmail_msg">
>      message(FATAL_ERROR "LLVM_USE_SANITIZER is not supported on this platform.")<br class="gmail_msg">
>    endif()<br class="gmail_msg">
> +  if (LLVM_USE_SANITIZER MATCHES "(Undefined;)?Address(;Undefined)?")<br class="gmail_msg">
> +    append("-fsanitize-address-use-after-scope" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br class="gmail_msg">
<br class="gmail_msg">
This isn't right. -fsanitize-address-use-after-scope is a fairly new<br class="gmail_msg">
flag, so this will fail to even be able to build anywhere where the host<br class="gmail_msg">
clang isn't bleeding edge. Instead, we should be using<br class="gmail_msg">
add_flag_if_supported here, which I've done for you in r292423.<br class="gmail_msg">
<br class="gmail_msg">
> +  endif()<br class="gmail_msg">
>    if (LLVM_USE_SANITIZE_COVERAGE)<br class="gmail_msg">
>      append("-fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br class="gmail_msg">
>    endif()<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> llvm-commits mailing list<br class="gmail_msg">
> <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>