<div dir="ltr">We could update DIPrinter, which is being used by LLVM symbolizer to print all the info. That should be relatively simple.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 17, 2017 at 2:17 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><span class=""><div dir="ltr">On Tue, Jan 17, 2017 at 2:10 PM Simon Que via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sque added a comment.<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
In <a href="https://reviews.llvm.org/D27962#647456" rel="noreferrer" class="m_-138398630743351226gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D27962#647456</a>, @dblaikie wrote:<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
> Also - what's the use case for this? (& test coverage would be good/necessary)<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
Use case: Internal use case, will email you about it.<br class="m_-138398630743351226gmail_msg"></blockquote><div><br></div></span><div>Would it be possible to motivate these changes with improvements to llvm-symbolizer (since we use that internally, seems like maybe improvements to internal symbolication things might be good to have in llvm-symbolizer too & that'd make it easier to carry these changes upstream (since then regressions would be more obvious and other developers would have a stronger motivation/demonstration of the value/need for these features))?<br><br>Don't want to sign you up for lots of work, but can be a bit tricky carrying unused code upstream like this.<br><br>(perhaps Eric can weigh in on what he's got/had in mind here)</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="m_-138398630743351226gmail_msg">
Unit test: No unit test exists for DWARFContext, but I added one here, awaiting review: <a href="https://reviews.llvm.org/D28428" rel="noreferrer" class="m_-138398630743351226gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D28428</a><br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
(Both are already mentioned earlier in this thread)<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
<a href="https://reviews.llvm.org/D27962" rel="noreferrer" class="m_-138398630743351226gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D27962</a><br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
<br class="m_-138398630743351226gmail_msg">
</blockquote></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Simon Que<div>Software Engineer</div></div></div>
</div>