<div dir="ltr">Oh! whoops. Thanks. </div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 17, 2017 at 2:50 PM, Marina Yatsina via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">myatsina added a comment.<br>
<span class=""><br>
In <a href="https://reviews.llvm.org/D28468#648538" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D28468#648538</a>, @niravd wrote:<br>
<br>
> In <a href="https://reviews.llvm.org/D28468#648513" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D28468#648513</a>, @myatsina wrote:<br>
><br>
> > Can you see the tests? I've added comments next to them.<br>
> >  Do this tests capture what you meant?<br>
><br>
><br>
> Yes.<br>
><br>
> But I thought you also had one using llvm-objdump so we also test the object->instruction disassembly path.<br>
<br>
<br>
</span>The llvm-objdump tests are the newly added data-prefix16.s, data-prefix32.s, data-prefix64.s which have the following run line:<br>
<br>
RUN: llvm-mc -triple<triple> -filetype=obj %s -o - | llvm-objdump -triple <triple> -d - | FileCheck %s<br>
==============================<wbr>==============================<wbr>==============================<wbr>============<br>
<br>
I will add to those tests the "data16"/"data32" disassembly once I tweak the asm printer.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D28468" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D28468</a><br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div>