<div dir="ltr">Actually the right way is to use PRIu64, but well, I think I prefer "ll".</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 16, 2017 at 10:48 AM, Rafael Avila de Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks!<br>
<div class="HOEnZb"><div class="h5">George Rimar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> writes:<br>
<br>
> Author: grimar<br>
> Date: Mon Jan 16 05:35:38 2017<br>
> New Revision: 292102<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=292102&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=292102&view=rev</a><br>
> Log:<br>
> [ELF] - Fix format specifiers in writeOutSecLine()<br>
><br>
> I had a error in map-file.s testcase under MSVS2015/win32:<br>
><br>
> map-file.s:30:16: error: expected string not found in input<br>
> // CHECK-NEXT: 0000000000200158 0000000000000030 8 .eh_frame<br>
><br>
> <stdin>:2:1: note: scanning from here<br>
> 0000000000200158 10 30 .eh_frame<br>
><br>
> Format string '%0*x' requires an argument of type 'unsigned int',<br>
> but argument has type 'uint64_t'. Proper format is '%0*llx' then.<br>
><br>
> This fixes testcase failture for me.<br>
><br>
> Modified:<br>
>     lld/trunk/ELF/MapFile.cpp<br>
><br>
> Modified: lld/trunk/ELF/MapFile.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/MapFile.cpp?rev=292102&r1=292101&r2=292102&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/MapFile.<wbr>cpp?rev=292102&r1=292101&r2=<wbr>292102&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- lld/trunk/ELF/MapFile.cpp (original)<br>
> +++ lld/trunk/ELF/MapFile.cpp Mon Jan 16 05:35:38 2017<br>
> @@ -35,7 +35,7 @@ using namespace lld::elf;<br>
><br>
>  static void writeOutSecLine(raw_fd_ostream &OS, int Width, uint64_t Address,<br>
>                              uint64_t Size, uint64_t Align, StringRef Name) {<br>
> -  OS << format("%0*x %0*x %5x ", Width, Address, Width, Size, Align)<br>
> +  OS << format("%0*llx %0*llx %5llx ", Width, Address, Width, Size, Align)<br>
>       << left_justify(Name, 7);<br>
>  }<br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>