<div dir="ltr">Looks like this was signed off on Phab but no email ever made it to the mailing list (making this look like code was sent for review, but committed without review being completed).<br><br>Richard - looks like Phab doesn't send email unless there's some comment in the approval action. So you can put some comment there, like "LGTM" to make sure the approval is reflected on the mailing list.<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Jan 13, 2017 at 1:11 PM David L. Jones via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">dlj created this revision.<br class="gmail_msg">
dlj added a reviewer: rsmith.<br class="gmail_msg">
dlj added a subscriber: llvm-commits.<br class="gmail_msg">
<br class="gmail_msg">
The LLVM coding standards recommend "using" values that are only<br class="gmail_msg">
needed by asserts:<br class="gmail_msg">
<a href="http://llvm.org/docs/CodingStandards.html#assert-liberally" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/docs/CodingStandards.html#assert-liberally</a><br class="gmail_msg">
<br class="gmail_msg">
Without this change, LLVM cannot bootstrap with -Werror as the second<br class="gmail_msg">
stage fails with this new warning:<br class="gmail_msg">
<a href="https://reviews.llvm.org/rL291905" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/rL291905</a><br class="gmail_msg">
<br class="gmail_msg">
See also the previous fixes:<br class="gmail_msg">
<a href="https://reviews.llvm.org/rL291916" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/rL291916</a><br class="gmail_msg">
<a href="https://reviews.llvm.org/rL291939" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/rL291939</a><br class="gmail_msg">
<a href="https://reviews.llvm.org/rL291940" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/rL291940</a><br class="gmail_msg">
<a href="https://reviews.llvm.org/rL291941" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/rL291941</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D28695" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28695</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
lib/Target/Hexagon/HexagonBitSimplify.cpp<br class="gmail_msg">
lib/Transforms/Scalar/SROA.cpp<br class="gmail_msg">
lib/Transforms/Utils/ValueMapper.cpp<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Index: lib/Transforms/Utils/ValueMapper.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- lib/Transforms/Utils/ValueMapper.cpp<br class="gmail_msg">
+++ lib/Transforms/Utils/ValueMapper.cpp<br class="gmail_msg">
@@ -681,6 +681,7 @@<br class="gmail_msg">
remapOperands(*ClonedN, [this, &D, &G](Metadata *Old) {<br class="gmail_msg">
if (Optional<Metadata *> MappedOp = getMappedOp(Old))<br class="gmail_msg">
return *MappedOp;<br class="gmail_msg">
+ (void)D;<br class="gmail_msg">
assert(G.Info[Old].ID > <a href="http://D.ID" rel="noreferrer" class="gmail_msg" target="_blank">D.ID</a> && "Expected a forward reference");<br class="gmail_msg">
return &G.getFwdReference(*cast<MDNode>(Old));<br class="gmail_msg">
});<br class="gmail_msg">
Index: lib/Transforms/Scalar/SROA.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- lib/Transforms/Scalar/SROA.cpp<br class="gmail_msg">
+++ lib/Transforms/Scalar/SROA.cpp<br class="gmail_msg">
@@ -1825,6 +1825,7 @@<br class="gmail_msg">
// Rank the remaining candidate vector types. This is easy because we know<br class="gmail_msg">
// they're all integer vectors. We sort by ascending number of elements.<br class="gmail_msg">
auto RankVectorTypes = [&DL](VectorType *RHSTy, VectorType *LHSTy) {<br class="gmail_msg">
+ (void)DL;<br class="gmail_msg">
assert(DL.getTypeSizeInBits(RHSTy) == DL.getTypeSizeInBits(LHSTy) &&<br class="gmail_msg">
"Cannot have vector types of different sizes!");<br class="gmail_msg">
assert(RHSTy->getElementType()->isIntegerTy() &&<br class="gmail_msg">
Index: lib/Target/Hexagon/HexagonBitSimplify.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- lib/Target/Hexagon/HexagonBitSimplify.cpp<br class="gmail_msg">
+++ lib/Target/Hexagon/HexagonBitSimplify.cpp<br class="gmail_msg">
@@ -896,6 +896,7 @@<br class="gmail_msg">
*MRI.getTargetRegisterInfo());<br class="gmail_msg">
<br class="gmail_msg">
auto VerifySR = [&HRI] (const TargetRegisterClass *RC, unsigned Sub) -> void {<br class="gmail_msg">
+ (void)HRI;<br class="gmail_msg">
assert(Sub == HRI.getHexagonSubRegIndex(RC, Hexagon::ps_sub_lo) ||<br class="gmail_msg">
Sub == HRI.getHexagonSubRegIndex(RC, Hexagon::ps_sub_hi));<br class="gmail_msg">
};<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>