<div dir="ltr">Test coverage?<br><br>I assume now that it's error rather than fatal, there's some other reachable functionality? (eg, I guess, if you pass two files - the first of which fails to open, the second is processed after this patch where  it wasn't previously?)</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Jan 15, 2017 at 5:18 PM Rui Ueyama via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br class="gmail_msg">
Date: Sun Jan 15 19:07:19 2017<br class="gmail_msg">
New Revision: 292090<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=292090&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=292090&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Use error() instead of fatal() to handle file open error.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    lld/trunk/ELF/MapFile.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: lld/trunk/ELF/MapFile.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/MapFile.cpp?rev=292090&r1=292089&r2=292090&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/MapFile.cpp?rev=292090&r1=292089&r2=292090&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lld/trunk/ELF/MapFile.cpp (original)<br class="gmail_msg">
+++ lld/trunk/ELF/MapFile.cpp Sun Jan 15 19:07:19 2017<br class="gmail_msg">
@@ -122,8 +122,9 @@ void elf::writeMapFile(ArrayRef<OutputSe<br class="gmail_msg">
   std::error_code EC;<br class="gmail_msg">
   raw_fd_ostream OS(Config->MapFile, EC, sys::fs::F_None);<br class="gmail_msg">
   if (EC)<br class="gmail_msg">
-    fatal("cannot open " + Config->MapFile + ": " + EC.message());<br class="gmail_msg">
-  writeMapFile2<ELFT>(OS, OutputSections);<br class="gmail_msg">
+    error("cannot open " + Config->MapFile + ": " + EC.message());<br class="gmail_msg">
+  else<br class="gmail_msg">
+    writeMapFile2<ELFT>(OS, OutputSections);<br class="gmail_msg">
 }<br class="gmail_msg">
<br class="gmail_msg">
 template void elf::writeMapFile<ELF32LE>(ArrayRef<OutputSectionBase *>);<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>