<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yep, I abandoned this an already have a new patch that switches over to use getValueOr.<div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 10, 2017, at 9:22 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">On closer inspection it looks like llvm::Optional might already have what you need - a 'getValueOr' member function. Is that it?</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, Jan 10, 2017 at 8:49 PM Greg Clayton via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">clayborg added a comment.<br class="gmail_msg">
<br class="gmail_msg">
Do we want the case to be:<br class="gmail_msg">
<br class="gmail_msg">
llvm::ValueOr(...)<br class="gmail_msg">
<br class="gmail_msg">
or<br class="gmail_msg">
<br class="gmail_msg">
llvm::value_or(...)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D28544" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28544</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>