<div dir="ltr">I think I mentioned this in a previous code review - is the special case for depth 1 worth keeping? I'd suggest removing it to simplify the code, I doubt it makes a big difference.<br><br>- Dave</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 3, 2017 at 4:21 PM Phabricator via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
Closed by commit rL290918: Correct the parent testing to avoid the special case where a DIE has a depth of… (authored by gclayton).<br class="gmail_msg">
<br class="gmail_msg">
Changed prior to commit:<br class="gmail_msg">
  <a href="https://reviews.llvm.org/D28261?vs=82967&id=82971#toc" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28261?vs=82967&id=82971#toc</a><br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D28261" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28261</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>