<div dir="ltr">Any chance of fixing the constness in 'P' instead of const casting away? (ie: if this really needs to be mutable, P should be non-const void*) Or if it doesn't need to be non-const, perhaps DIEInteger needs a fix?<br><br>Also, it looks like you have extra () around the const_cast - remove them?</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 27, 2016 at 10:46 AM Saleem Abdulrasool via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: compnerd<br class="gmail_msg">
Date: Tue Dec 27 12:35:24 2016<br class="gmail_msg">
New Revision: 290618<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290618&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=290618&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
DebugInfo: add explicit casts for -Wqual-cast<br class="gmail_msg">
<br class="gmail_msg">
Fix a warning detected by gcc 6:<br class="gmail_msg">
  warning: cast from type 'const void*' to type 'uint8_t* {aka unsigned char*}' casts away qualifiers [-Wcast-qual]<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp?rev=290618&r1=290617&r2=290618&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp?rev=290618&r1=290617&r2=290618&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/unittests/DebugInfo/DWARF/DwarfGenerator.cpp Tue Dec 27 12:35:24 2016<br class="gmail_msg">
@@ -81,8 +81,10 @@ void dwarfgen::DIE::addAttribute(uint16_<br class="gmail_msg">
   auto &DG = CU->getGenerator();<br class="gmail_msg">
   DIEBlock *Block = new (DG.getAllocator()) DIEBlock;<br class="gmail_msg">
   for (size_t I = 0; I < S; ++I)<br class="gmail_msg">
-    Block->addValue(DG.getAllocator(), (dwarf::Attribute)0,<br class="gmail_msg">
-                    dwarf::DW_FORM_data1, DIEInteger(((uint8_t *)P)[I]));<br class="gmail_msg">
+    Block->addValue(<br class="gmail_msg">
+        DG.getAllocator(), (dwarf::Attribute)0, dwarf::DW_FORM_data1,<br class="gmail_msg">
+        DIEInteger(<br class="gmail_msg">
+            (const_cast<uint8_t *>(static_cast<const uint8_t *>(P)))[I]));<br class="gmail_msg">
<br class="gmail_msg">
   Block->ComputeSize(DG.getAsmPrinter());<br class="gmail_msg">
   Die->addValue(DG.getAllocator(), static_cast<dwarf::Attribute>(A), Form,<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>