<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jan 1, 2017 at 9:18 AM, Sanjay Patel via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: spatel<br>
Date: Sun Jan  1 11:18:00 2017<br>
New Revision: 290797<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290797&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290797&view=rev</a><br>
Log:<br>
[InstCombine] add test to show potential nonnull attribute propagation; NFC<br></blockquote><div><br></div><div>Can you describe the "potential" in a comment in the test case? It's clear from context for me right now, but these things can get lost in the mists of time. </div><div><br></div><div>-- Sean Silva</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
This will change with the current draft of:<br>
<a href="https://reviews.llvm.org/D28204" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D28204</a><br>
<br>
Modified:<br>
    llvm/trunk/test/Transforms/<wbr>InstCombine/call_nonnull_arg.<wbr>ll<br>
<br>
Modified: llvm/trunk/test/Transforms/<wbr>InstCombine/call_nonnull_arg.<wbr>ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/call_nonnull_arg.ll?rev=290797&r1=290796&r2=290797&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/InstCombine/call_<wbr>nonnull_arg.ll?rev=290797&r1=<wbr>290796&r2=290797&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/Transforms/<wbr>InstCombine/call_nonnull_arg.<wbr>ll (original)<br>
+++ llvm/trunk/test/Transforms/<wbr>InstCombine/call_nonnull_arg.<wbr>ll Sun Jan  1 11:18:00 2017<br>
@@ -31,3 +31,17 @@ dead:<br>
   unreachable<br>
 }<br>
<br>
+declare void @bar(i8*, i8* nonnull)<br>
+declare void @baz(i8*, i8*)<br>
+<br>
+define void @deduce_nonnull_from_another_<wbr>call(i8* %a, i8* %b) {<br>
+; CHECK-LABEL: @deduce_nonnull_from_another_<wbr>call(<br>
+; CHECK-NEXT:    call void @bar(i8* %a, i8* %b)<br>
+; CHECK-NEXT:    call void @baz(i8* %b, i8* %b)<br>
+; CHECK-NEXT:    ret void<br>
+;<br>
+  call void @bar(i8* %a, i8* %b)<br>
+  call void @baz(i8* %b, i8* %b)<br>
+  ret void<br>
+}<br>
+<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>