<div dir="ltr">Sorry. Daniel Berlin asked me to revert it because we should firstly get consensus in Coding Style</div><div class="gmail_extra"><br><div class="gmail_quote">2016-12-29 1:20 GMT+01:00 Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Can you add the reason for revert in the future? That’s helpful to understand what’s going on when reading the llvm-commits mailing-list.<br>
<br>
Thanks,<br>
<br>
—<br>
<span class="HOEnZb"><font color="#888888">Mehdi<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> On Dec 28, 2016, at 3:24 PM, Piotr Padlewski via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: prazek<br>
> Date: Wed Dec 28 17:24:02 2016<br>
> New Revision: 290692<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290692&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290692&view=rev</a><br>
> Log:<br>
> Revert "[NewGVN] replace emplace_back with push_back"<br>
><br>
> Modified:<br>
>    llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=290692&r1=290691&r2=290692&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/NewGVN.cpp?<wbr>rev=290692&r1=290691&r2=<wbr>290692&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp Wed Dec 28 17:24:02 2016<br>
> @@ -277,7 +277,7 @@ private:<br>
>   // Congruence class handling.<br>
>   CongruenceClass *createCongruenceClass(Value *Leader, const Expression *E) {<br>
>     auto *result = new CongruenceClass(<wbr>NextCongruenceNum++, Leader, E);<br>
> -    CongruenceClasses.push_back(<wbr>result);<br>
> +    CongruenceClasses.emplace_<wbr>back(result);<br>
>     return result;<br>
>   }<br>
><br>
> @@ -589,7 +589,7 @@ const Expression *NewGVN::createExpressi<br>
><br>
>     SmallVector<Constant *, 8> C;<br>
>     for (Value *Arg : E->operands())<br>
> -      C.push_back(cast<Constant>(<wbr>Arg));<br>
> +      C.emplace_back(cast<Constant>(<wbr>Arg));<br>
><br>
>     if (Value *V = ConstantFoldInstOperands(I, C, *DL, TLI))<br>
>       if (const Expression *SimplifiedE = checkSimplificationResults(E, I, V))<br>
> @@ -1256,12 +1256,12 @@ std::pair<unsigned, unsigned> NewGVN::as<br>
>   unsigned End = Start;<br>
>   if (MemoryAccess *MemPhi = MSSA->getMemoryAccess(B)) {<br>
>     InstrDFS[MemPhi] = End++;<br>
> -    DFSToInstr.push_back(MemPhi);<br>
> +    DFSToInstr.emplace_back(<wbr>MemPhi);<br>
>   }<br>
><br>
>   for (auto &I : *B) {<br>
>     InstrDFS[&I] = End++;<br>
> -    DFSToInstr.push_back(&I);<br>
> +    DFSToInstr.emplace_back(&I);<br>
>   }<br>
><br>
>   // All of the range functions taken half-open ranges (open on the end side).<br>
> @@ -1585,7 +1585,7 @@ void NewGVN::<wbr>convertDenseToDFSOrdered(Co<br>
>     else<br>
>       llvm_unreachable("Should have been an instruction");<br>
><br>
> -    DFSOrderedSet.push_back(VD);<br>
> +    DFSOrderedSet.emplace_back(VD)<wbr>;<br>
><br>
>     // Now add the users.<br>
>     for (auto &U : D->uses()) {<br>
> @@ -1606,7 +1606,7 @@ void NewGVN::<wbr>convertDenseToDFSOrdered(Co<br>
>         VD.DFSIn = DFSPair.first;<br>
>         VD.DFSOut = DFSPair.second;<br>
>         VD.U = &U;<br>
> -        DFSOrderedSet.push_back(VD);<br>
> +        DFSOrderedSet.emplace_back(VD)<wbr>;<br>
>       }<br>
>     }<br>
>   }<br>
> @@ -1695,7 +1695,7 @@ public:<br>
>   std::pair<int, int> dfs_back() const { return DFSStack.back(); }<br>
><br>
>   void push_back(Value *V, int DFSIn, int DFSOut) {<br>
> -    ValueStack.push_back(V);<br>
> +    ValueStack.emplace_back(V);<br>
>     DFSStack.emplace_back(DFSIn, DFSOut);<br>
>   }<br>
>   bool empty() const { return DFSStack.empty(); }<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div>