<div dir="ltr">2 main reasons why using is better:<div>- it is cleaner, specially in cases like</div><div>  using vptr = void (*)(int);</div><div>- it works with templates</div><div>template <typename T></div><div>using MyVec = std::SmallVector<T, 10>;</div><div><br></div><div>I will try to start thread soon about changing coding standards to use these features more conservatively in new code.</div><div><br></div><div>I guess the only reason why people use typedefs is just habbits, but this is easy to change.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-12-28 23:05 GMT+01:00 Sanjoy Das <span dir="ltr"><<a href="mailto:sanjoy@playingwithpointers.com" target="_blank">sanjoy@playingwithpointers.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Piotr,<br>
<br>
Is there a tangible benefit to doing this replacement?<br>
<br>
I'd rather not have the codebase be a mix of typedefs and using<br>
directives.  If one is more preferable than the other for some reason<br>
then we should note that in the coding style and slowly migrate the<br>
whole codebase towards that.<br>
<br>
-- Sanjoy<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Dec 28, 2016 at 11:29 AM, Piotr Padlewski via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: prazek<br>
> Date: Wed Dec 28 13:29:26 2016<br>
> New Revision: 290680<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290680&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290680&view=rev</a><br>
> Log:<br>
> [NewGVN] replace typedefs with usings<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=290680&r1=290679&r2=290680&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/NewGVN.cpp?<wbr>rev=290680&r1=290679&r2=<wbr>290680&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/<wbr>Scalar/NewGVN.cpp Wed Dec 28 13:29:26 2016<br>
> @@ -120,7 +120,7 @@ PHIExpression::~PHIExpression(<wbr>) = defaul<br>
>  // propagation and reassociation of values.<br>
>  //<br>
>  struct CongruenceClass {<br>
> -  typedef SmallPtrSet<Value *, 4> MemberSet;<br>
> +  using MemberSet = SmallPtrSet<Value *, 4>;<br>
>    unsigned ID;<br>
>    // Representative leader.<br>
>    Value *RepLeader = nullptr;<br>
> @@ -192,7 +192,7 @@ class NewGVN : public FunctionPass {<br>
>    DenseMap<MemoryAccess *, MemoryAccess *> MemoryAccessEquiv;<br>
><br>
>    // Expression to class mapping.<br>
> -  typedef DenseMap<const Expression *, CongruenceClass *> ExpressionClassMap;<br>
> +  using ExpressionClassMap = DenseMap<const Expression *, CongruenceClass *>;<br>
>    ExpressionClassMap ExpressionToClass;<br>
><br>
>    // Which values have changed as a result of leader changes.<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Sanjoy Das<br>
<a href="http://playingwithpointers.com" rel="noreferrer" target="_blank">http://playingwithpointers.com</a><br>
</font></span></blockquote></div><br></div>