<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 23, 2016, at 4:50 AM, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" class="">peter@pcc.me.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="auto" class=""><div class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Dec 23, 2016 5:26 AM, "Mehdi Amini via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution" class=""><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mehdi_amini<br class="">
Date: Thu Dec 22 23:16:19 2016<br class="">
New Revision: 290416<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290416&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=290416&view=rev</a><br class="">
Log:<br class="">
[ThinLTO] Verify lazy-loaded source module for function importing when assertions are enabled (NFC)<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Transforms/IPO/<wbr class="">FunctionImport.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Transforms/IPO/<wbr class="">FunctionImport.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp?rev=290416&r1=290415&r2=290416&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/lib/<wbr class="">Transforms/IPO/FunctionImport.<wbr class="">cpp?rev=290416&r1=290415&r2=<wbr class="">290416&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/Transforms/IPO/<wbr class="">FunctionImport.cpp (original)<br class="">
+++ llvm/trunk/lib/Transforms/IPO/<wbr class="">FunctionImport.cpp Thu Dec 22 23:16:19 2016<br class="">
@@ -697,6 +697,14 @@ Expected<bool> FunctionImporter::importF<br class="">
}<br class="">
}<br class="">
<br class="">
+#ifndef DEBUG<br class=""></blockquote></div></div></div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">NDEBUG?</div></div></div></blockquote><div><br class=""></div><div><br class=""></div><div>Indeed! r290437.</div><div><br class=""></div><div>Thanks.</div><div><br class=""></div><div>Mehdi</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="auto" class=""><div dir="auto" class=""><br class=""></div><div dir="auto" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ // Note: this can't be done after `renameModuleForThinLTO` as it leaves the<br class="">
+ // module in a state that does not pass the verifier (for example aliases<br class="">
+ // pointing to available_externally functions).<br class="">
+ if (verifyModule(*SrcModule, &errs()))<br class="">
+ report_fatal_error("Invalid lazy-loaded source module for importing");<br class="">
+#endif<br class="">
+<br class="">
// Link in the specified functions.<br class="">
if (renameModuleForThinLTO(*<wbr class="">SrcModule, Index, &GlobalsToImport))<br class="">
return true;<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div></div></div>
</div></blockquote></div><br class=""></div>
</body></html>