<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Dec 23, 2016 5:26 AM, "Mehdi Amini via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mehdi_amini<br>
Date: Thu Dec 22 23:16:19 2016<br>
New Revision: 290416<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290416&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290416&view=rev</a><br>
Log:<br>
[ThinLTO] Verify lazy-loaded source module for function importing when assertions are enabled (NFC)<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp?rev=290416&r1=290415&r2=290416&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/IPO/FunctionImport.<wbr>cpp?rev=290416&r1=290415&r2=<wbr>290416&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp Thu Dec 22 23:16:19 2016<br>
@@ -697,6 +697,14 @@ Expected<bool> FunctionImporter::importF<br>
       }<br>
     }<br>
<br>
+#ifndef DEBUG<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">NDEBUG?</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+    // Note: this can't be done after `renameModuleForThinLTO` as it leaves the<br>
+    // module in a state that does not pass the verifier (for example aliases<br>
+    // pointing to available_externally functions).<br>
+    if (verifyModule(*SrcModule, &errs()))<br>
+      report_fatal_error("Invalid lazy-loaded source module for importing");<br>
+#endif<br>
+<br>
     // Link in the specified functions.<br>
     if (renameModuleForThinLTO(*<wbr>SrcModule, Index, &GlobalsToImport))<br>
       return true;<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div>