<div dir="ltr">I can't really reproduce Andrey's original problem (_byteswap_ushort compiles for me just fine without this include), but if I change this to <cstdlib> then I assume I have to change _byteswap_ushort to std::_byteswap_ushort, and yet that fails.  So I'm not really sure<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 21, 2016 at 11:06 AM Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Dec 21, 2016 at 1:50 PM, Zachary Turner via llvm-commits<br class="gmail_msg">
<<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
> Author: zturner<br class="gmail_msg">
> Date: Wed Dec 21 12:50:52 2016<br class="gmail_msg">
> New Revision: 290263<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290263&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=290263&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> Add missing includes on Windows.<br class="gmail_msg">
><br class="gmail_msg">
> Patch by Andrey Khalyavin<br class="gmail_msg">
> Differential Revision: <a href="https://reviews.llvm.org/D27915" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27915</a><br class="gmail_msg">
><br class="gmail_msg">
> Modified:<br class="gmail_msg">
>     llvm/trunk/include/llvm/Support/SwapByteOrder.h<br class="gmail_msg">
>     llvm/trunk/lib/Support/Windows/Signals.inc<br class="gmail_msg">
><br class="gmail_msg">
> Modified: llvm/trunk/include/llvm/Support/SwapByteOrder.h<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/SwapByteOrder.h?rev=290263&r1=290262&r2=290263&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/SwapByteOrder.h?rev=290263&r1=290262&r2=290263&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- llvm/trunk/include/llvm/Support/SwapByteOrder.h (original)<br class="gmail_msg">
> +++ llvm/trunk/include/llvm/Support/SwapByteOrder.h Wed Dec 21 12:50:52 2016<br class="gmail_msg">
> @@ -18,6 +18,9 @@<br class="gmail_msg">
>  #include "llvm/Support/Compiler.h"<br class="gmail_msg">
>  #include "llvm/Support/DataTypes.h"<br class="gmail_msg">
>  #include <cstddef><br class="gmail_msg">
> +#if defined(_MSC_VER) && !defined(_DEBUG)<br class="gmail_msg">
> +#include <stdlib.h><br class="gmail_msg">
<br class="gmail_msg">
<cstdlib> instead of <stdlib.h>?<br class="gmail_msg">
<br class="gmail_msg">
~Aaron<br class="gmail_msg">
<br class="gmail_msg">
> +#endif<br class="gmail_msg">
><br class="gmail_msg">
>  namespace llvm {<br class="gmail_msg">
>  namespace sys {<br class="gmail_msg">
><br class="gmail_msg">
> Modified: llvm/trunk/lib/Support/Windows/Signals.inc<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Windows/Signals.inc?rev=290263&r1=290262&r2=290263&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Windows/Signals.inc?rev=290263&r1=290262&r2=290263&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- llvm/trunk/lib/Support/Windows/Signals.inc (original)<br class="gmail_msg">
> +++ llvm/trunk/lib/Support/Windows/Signals.inc Wed Dec 21 12:50:52 2016<br class="gmail_msg">
> @@ -28,6 +28,7 @@<br class="gmail_msg">
>  #ifdef __MINGW32__<br class="gmail_msg">
>   #include <imagehlp.h><br class="gmail_msg">
>  #else<br class="gmail_msg">
> + #include <crtdbg.h><br class="gmail_msg">
>   #include <dbghelp.h><br class="gmail_msg">
>  #endif<br class="gmail_msg">
>  #include <psapi.h><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> llvm-commits mailing list<br class="gmail_msg">
> <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>