<div dir="ltr">Whoops -- I'll revert (if it hasn't been reverted yet).</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 16, 2016 at 4:53 AM Ismail Donmez <<a href="mailto:ismail@i10z.com">ismail@i10z.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br class="gmail_msg">
<br class="gmail_msg">
On Thu, Dec 15, 2016 at 10:04 AM, Dean Michael Berris via llvm-commits<br class="gmail_msg">
<<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
> Author: dberris<br class="gmail_msg">
> Date: Thu Dec 15 03:04:05 2016<br class="gmail_msg">
> New Revision: 289789<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289789&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=289789&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> [XRay][compiler-rt][NFC] Deduplicate code in x86-64 trampolines.<br class="gmail_msg">
><br class="gmail_msg">
> Summary:<br class="gmail_msg">
> The layout of all registers saved on stack shouldn't deviate and will be reused in future trampolines as well.<br class="gmail_msg">
><br class="gmail_msg">
> While there, fix whitespace and clarify comments.<br class="gmail_msg">
><br class="gmail_msg">
> Author: mpel<br class="gmail_msg">
><br class="gmail_msg">
> Reviewers: dberris<br class="gmail_msg">
><br class="gmail_msg">
> Subscribers: llvm-commits<br class="gmail_msg">
><br class="gmail_msg">
> Differential Revision: <a href="https://reviews.llvm.org/D27799" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27799</a><br class="gmail_msg">
><br class="gmail_msg">
> Modified:<br class="gmail_msg">
>     compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S<br class="gmail_msg">
<br class="gmail_msg">
This doesn't compile on Linux x86-64 (using the integrated assembler):<br class="gmail_msg">
<br class="gmail_msg">
[ 1311s] /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:33:7:<br class="gmail_msg">
error: unexpected token in '.endm' directive<br class="gmail_msg">
[ 1311s] .endm SAVE_REGISTERS<br class="gmail_msg">
[ 1311s]       ^<br class="gmail_msg">
[ 1311s] /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:52:7:<br class="gmail_msg">
error: unexpected token in '.endm' directive<br class="gmail_msg">
[ 1311s] .endm RESTORE_REGISTERS<br class="gmail_msg">
[ 1311s]       ^<br class="gmail_msg">
[ 1311s] /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:64:2:<br class="gmail_msg">
error: invalid instruction mnemonic 'save_registers'<br class="gmail_msg">
[ 1311s]  SAVE_REGISTERS<br class="gmail_msg">
[ 1311s]  ^~~~~~~~~~~~~~<br class="gmail_msg">
[ 1311s] /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:77:2:<br class="gmail_msg">
error: invalid instruction mnemonic 'restore_registers'<br class="gmail_msg">
[ 1311s]  RESTORE_REGISTERS<br class="gmail_msg">
[ 1311s]  ^~~~~~~~~~~~~~~~~<br class="gmail_msg">
[ 1311s] /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:131:2:<br class="gmail_msg">
error: invalid instruction mnemonic 'save_registers'<br class="gmail_msg">
[ 1311s]  SAVE_REGISTERS<br class="gmail_msg">
[ 1311s]  ^~~~~~~~~~~~~~<br class="gmail_msg">
[ 1311s] /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:142:2:<br class="gmail_msg">
error: invalid instruction mnemonic 'restore_registers'<br class="gmail_msg">
[ 1311s]  RESTORE_REGISTERS<br class="gmail_msg">
[ 1311s]  ^~~~~~~~~~~~~~~~~<br class="gmail_msg">
</blockquote></div>