<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I've added a new flag to ignore libLLVM, can you please see if r289605 resolves your issue?<div class=""><div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 13, 2016, at 2:27 PM, Derek Schuff <<a href="mailto:dschuff@google.com" class="">dschuff@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="gmail_msg">Hm, for the BUILD_SHARED_LIBS case, it is actually true that there are no static libs built, and even if llvm-config --libs --link-static outputs the correct flags (-lSupport etc) a link using those flags will fail (or end up linking against the DSOs). Is that the behavior we want anyway?</div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Tue, Dec 13, 2016 at 2:19 PM Chris Bieneman <<a href="mailto:beanz@apple.com" class="gmail_msg cremed" target="_blank">beanz@apple.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg">That's a bug in llvm-config that needs to get fixed.</div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">-Chris</div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Dec 13, 2016, at 2:18 PM, Derek Schuff <<a href="mailto:dschuff@google.com" class="gmail_msg cremed" target="_blank">dschuff@google.com</a>> wrote:</div><br class="gmail_msg m_-1033370591230127096m_-602604874696918748Apple-interchange-newline"><div class="gmail_msg"><div dir="ltr" class="gmail_msg">Hm, sort of?<div class="gmail_msg">It does print the right thing for the dylib build. However when I try to use it with a -DBUILD_SHARED_LIBS build, llvm-config throws errors:</div><div class="gmail_msg"><div class="gmail_msg"># bin/llvm-config --libs --link-static</div><div class="gmail_msg">llvm-config: error: missing: /s/llvm-upstream/build/lib/libLLVMDemangle.a</div><div class="gmail_msg">llvm-config: error: missing: /s/llvm-upstream/build/lib/libLLVMSupport.a</div></div><div class="gmail_msg">... etc.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Ironically, that would probably actually make the test pass as written :/</div></div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Tue, Dec 13, 2016 at 2:07 PM Chris Bieneman <<a href="mailto:beanz@apple.com" class="gmail_msg cremed" target="_blank">beanz@apple.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg">I believe the flag --link-static covers this use case.</div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">-Chris</div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Dec 13, 2016, at 2:02 PM, Derek Schuff <<a href="mailto:dschuff@google.com" class="gmail_msg cremed" target="_blank">dschuff@google.com</a>> wrote:</div><br class="gmail_msg m_-1033370591230127096m_-602604874696918748m_-1314230088674469002Apple-interchange-newline"><div class="gmail_msg"><div dir="ltr" class="gmail_msg">Hi Chris,<div class="gmail_msg">There does seem to be one bit of breakage hiding behind this disabled test; namely for the LLVM_{BUILD,LINK}_LLVM_DYLIB case, where `llvm-config --libs` emits '-lLLVM-4.0svn` rather than '-lLLVMCore' etc. tools/llvm-config/libs.test explicitly checks that LLVMCore and LLVMSupport are included. Any ideas about how to support both build cases?</div></div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Mon, Dec 12, 2016 at 3:25 PM Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg cremed" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: cbieneman<br class="gmail_msg">
Date: Mon Dec 12 17:14:58 2016<br class="gmail_msg">
New Revision: 289490<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289490&view=rev" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://llvm.org/viewvc/llvm-project?rev=289490&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Revert "Disable all llvm-config tests for now, will investigate later"<br class="gmail_msg">
<br class="gmail_msg">
This reverts commit r260386.<br class="gmail_msg">
<br class="gmail_msg">
These tests all pass for me locally. I have no idea if they will pass on all configurations, so I'll watch the bots closely.<br class="gmail_msg">
<br class="gmail_msg">
Removed:<br class="gmail_msg">
llvm/trunk/test/tools/llvm-config/lit.local.cfg<br class="gmail_msg">
<br class="gmail_msg">
Removed: llvm/trunk/test/tools/llvm-config/lit.local.cfg<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-config/lit.local.cfg?rev=289489&view=auto" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-config/lit.local.cfg?rev=289489&view=auto</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/test/tools/llvm-config/lit.local.cfg (original)<br class="gmail_msg">
+++ llvm/trunk/test/tools/llvm-config/lit.local.cfg (removed)<br class="gmail_msg">
@@ -1,2 +0,0 @@<br class="gmail_msg">
-# Disable all llvm-config tests for now.<br class="gmail_msg">
-config.unsupported = True<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg cremed" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>
</div></blockquote></div><br class="gmail_msg"></div></div></blockquote></div>
</div></blockquote></div><br class="gmail_msg"></div></div></blockquote></div></div>
</div></blockquote></div><br class=""></div></div></body></html>