<div dir="ltr">Diana,<div><br></div><div>This test passing on ARM was a total surprise for me. rengolin was kind enough to require stable-runtime in my tests (not really sure what that means, but many thanks). The build got green afterwards.</div><div><br></div><div>Sorry for disturbance.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 12, 2016 at 10:49 PM Diana Picus <<a href="mailto:diana.picus@linaro.org">diana.picus@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Mike,<br class="gmail_msg">
<br class="gmail_msg">
This and r289505 are breaking the buildbots, because apparently the<br class="gmail_msg">
tests do pass on ARM:<br class="gmail_msg">
<a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/1489" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/1489</a><br class="gmail_msg">
<a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/1488" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/1488</a><br class="gmail_msg">
<br class="gmail_msg">
I'm not sure if this works as intended, but could you please either<br class="gmail_msg">
re-enable them on ARM or rewrite them so they don't accidentally pass<br class="gmail_msg">
on it?<br class="gmail_msg">
<br class="gmail_msg">
Thanks,<br class="gmail_msg">
Diana<br class="gmail_msg">
<br class="gmail_msg">
On 13 December 2016 at 03:11, Mike Aizatsky via llvm-commits<br class="gmail_msg">
<<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg cremed" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
> Author: aizatsky<br class="gmail_msg">
> Date: Mon Dec 12 19:11:46 2016<br class="gmail_msg">
> New Revision: 289508<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289508&view=rev" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://llvm.org/viewvc/llvm-project?rev=289508&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> [sanitizers] disabling dso test as well where appropriate<br class="gmail_msg">
><br class="gmail_msg">
> Modified:<br class="gmail_msg">
>     compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cc<br class="gmail_msg">
><br class="gmail_msg">
> Modified: compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cc<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cc?rev=289508&r1=289507&r2=289508&view=diff" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cc?rev=289508&r1=289507&r2=289508&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cc (original)<br class="gmail_msg">
> +++ compiler-rt/trunk/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cc Mon Dec 12 19:11:46 2016<br class="gmail_msg">
> @@ -1,7 +1,7 @@<br class="gmail_msg">
>  // Tests trace pc guard coverage collection.<br class="gmail_msg">
>  //<br class="gmail_msg">
>  // REQUIRES: has_sancovcc<br class="gmail_msg">
> -// XFAIL: tsan<br class="gmail_msg">
> +// XFAIL: tsan,arm,aarch64,darwin<br class="gmail_msg">
>  //<br class="gmail_msg">
>  // RUN: DIR=%t_workdir<br class="gmail_msg">
>  // RUN: CLANG_ARGS="-O0 -fsanitize-coverage=trace-pc-guard"<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> llvm-commits mailing list<br class="gmail_msg">
> <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg cremed" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Mike<br>Sent from phone</div></div>