Is EXPECT_STREQ not sufficient?<br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 12, 2016 at 11:53 PM Malcolm Parsons via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">malcolm.parsons requested changes to this revision.<br class="gmail_msg">
malcolm.parsons added inline comments.<br class="gmail_msg">
This revision now requires changes to proceed.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: unittests/ADT/StringRefTest.cpp:1007<br class="gmail_msg">
+  constexpr StringLiteral Strings[] = {"Foo", "Bar"};<br class="gmail_msg">
+  EXPECT_STREQ("Foo", Strings[0].data());<br class="gmail_msg">
+  EXPECT_STREQ("Bar", Strings[1].data());<br class="gmail_msg">
----------------<br class="gmail_msg">
There is no test for the length of the StrlingLiteral.<br class="gmail_msg">
Maybe `EXPECT_EQ(StringRef("Foo"), Strings[0]);`<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D27686" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27686</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>