<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 12, 2016 at 4:11 PM David Gross <<a href="mailto:dgross@google.com">dgross@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Per the Details:<div class="gmail_msg"><br class="gmail_msg"></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class="gmail_msg"></blockquote></div><div dir="ltr" class="gmail_msg"><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class="gmail_msg"><div class="gmail_msg"><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">Prior to the change "DebugInfo: New metadata representation for global</span></div></blockquote></div><div dir="ltr" class="gmail_msg"><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class="gmail_msg"><div class="gmail_msg"><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">variables." (</span><a href="https://reviews.llvm.org/D20147" class="m_-4118040117516390691gmail-phui-tag-view m_-4118040117516390691gmail-phui-tag-type-object gmail_msg" style="text-decoration:none;color:rgb(0,0,0);font-weight:bold;white-space:nowrap;font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" target="_blank"><span class="m_-4118040117516390691gmail-phui-tag-core-closed gmail_msg" style="text-decoration:line-through;color:rgba(0,0,0,0.498039);margin-top:0px"><span class="m_-4118040117516390691gmail-phui-tag-core m_-4118040117516390691gmail-phui-tag-color-object gmail_msg" style="color:rgb(0,0,0);border:1px solid rgb(231,231,231);border-radius:3px;padding:0px 4px;background-color:rgb(231,231,231);margin-top:0px">D20147</span></span></a><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">, </span><a href="https://reviews.llvm.org/D20415" class="m_-4118040117516390691gmail-phui-tag-view m_-4118040117516390691gmail-phui-tag-type-object gmail_msg" style="text-decoration:none;color:rgb(0,0,0);font-weight:bold;white-space:nowrap;font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" target="_blank"><span class="m_-4118040117516390691gmail-phui-tag-core-closed gmail_msg" style="text-decoration:line-through;color:rgba(0,0,0,0.498039);margin-top:0px"><span class="m_-4118040117516390691gmail-phui-tag-core m_-4118040117516390691gmail-phui-tag-color-object gmail_msg" style="color:rgb(0,0,0);border:1px solid rgb(231,231,231);border-radius:3px;padding:0px 4px;background-color:rgb(231,231,231);margin-top:0px">D20415</span></span></a><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">), clang emitted debug metadata for static</span></div></blockquote></div><div dir="ltr" class="gmail_msg"><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class="gmail_msg"><div class="gmail_msg"><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">const values of floating-point types, but llvm did not translate this</span></div><div class="gmail_msg"><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">debug metadata into DWARF. After that change, clang did not emit debug</span></div><div class="gmail_msg"><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">metadata for static const values of floating-point types, but llvm is</span></div><div class="gmail_msg"><span style="color:rgb(0,0,0);font-family:"segoe ui","segoe ui web regular","segoe ui symbol",lato,"helvetica neue",helvetica,arial,sans-serif;font-size:13px" class="gmail_msg">capable of translating it into DWARF if it is emitted.</span></div></blockquote></div><div dir="ltr" class="gmail_msg"><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class="gmail_msg"></blockquote><font color="#000000" face="segoe ui, segoe ui web regular, segoe ui symbol, lato, helvetica neue, helvetica, arial, sans-serif" class="gmail_msg"><br class="gmail_msg"></font><div class="gmail_msg"><font color="#000000" face="segoe ui, segoe ui web regular, segoe ui symbol, lato, helvetica neue, helvetica, arial, sans-serif" class="gmail_msg">My (perhaps overly cautious) concern is that given what has occurred in the past (where llvm was not emitting bytes for floating-point types), it's possible that there might be a change in the future which would cause the emission of the bytes to become type-sensitive again, and I'd like to be sure we do continue to emit the bytes for floating-point types.</font></div></div></blockquote><div><br>Hmm - could you point me to the particular parts of those changes (or roughly describe what was going on in the old code, and what goes on in the new code) that caused this change in behavior?<br><br>- Dave<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><font color="#000000" face="segoe ui, segoe ui web regular, segoe ui symbol, lato, helvetica neue, helvetica, arial, sans-serif" class="gmail_msg"><br class="gmail_msg"></font></div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Mon, Dec 12, 2016 at 3:47 PM, David Blaikie <span dir="ltr" class="gmail_msg"><<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><span class="gmail_msg"><div dir="ltr" class="gmail_msg">On Mon, Dec 12, 2016 at 3:24 PM David Gross via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="gmail_msg" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">dgross added a comment.<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
In <a href="https://reviews.llvm.org/D27551#620373" rel="noreferrer" class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D27551#620373</a>, @dblaikie wrote:<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
> Does this need the test coverage if it's just "hey, LLVM can splat these bytes out into DWARF even if we (independently) say the type of those bytes is a float"? The code that emits the bytes is presumably independent of the code that emits the type description, so testing the combination seems unnecessary to me.<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
Can you explain this further?  What parts of this test case are you suggesting may be unnecessary?<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg"></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></span><div class="gmail_msg">All of it. (partly under the argument that no code changes were required to provide this functionality, but to be more complete:<br class="gmail_msg"><br class="gmail_msg">* We already have test coverage for emitting the correct DW_AT_type value here<br class="gmail_msg">* We already have test coverage that the arbitrary bytes in the constant value are emitted into the right place in the DW_AT_const_value or whatnot<br class="gmail_msg"><br class="gmail_msg">So what's the particularly interesting thing about testing the combination of those two (so far as I can see) orthogonal features?)</div><div class="gmail_msg"> </div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<a href="https://reviews.llvm.org/D27551" rel="noreferrer" class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D27551</a><br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
<br class="m_-4118040117516390691m_-5303920041016513926gmail_msg gmail_msg">
</blockquote></div></div>
</blockquote></div><div style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif;font-size:13px;overflow:hidden;width:28px;height:28px"><input type="file" multiple tabindex="-1" style="font-size:28px;height:28px;width:28px;opacity:0"></div><div class="inbox-inbox-mb" style="min-width:0px;display:flex;color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif;font-size:13px"><div class="inbox-inbox-n" style="max-height:28px;overflow:hidden;display:inline-flex"><div class="inbox-inbox-g-W inbox-inbox-g-W-DKlKme" tabindex="-1" style="display:flex"><div class="inbox-inbox-g-W-Cw inbox-inbox-g-W-Cw-mD inbox-inbox-g-mu-sE" id="inbox-inbox-:np" style="display:inline-block;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;background-color:rgb(229,229,229);height:28px;margin:0px 6px;width:1px"> </div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="Bold" id="inbox-inbox-+bold" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-h-N inbox-inbox-h-c8csvc" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px"></div></div></div></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="Italic" id="inbox-inbox-+italic" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-h-N inbox-inbox-h-O807Gb" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px"></div></div></div></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="Underline" id="inbox-inbox-+underline" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-h-N inbox-inbox-h-NowJzb" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px"></div></div></div></div></div><div class="inbox-inbox-g-W inbox-inbox-g-W-DKlKme" tabindex="-1" style="display:flex"><div class="inbox-inbox-g-W-Cw inbox-inbox-g-W-Cw-mD inbox-inbox-g-mu-sE" id="inbox-inbox-:ny" style="display:inline-block;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;background-color:rgb(229,229,229);height:28px;margin:0px 6px;width:1px"> </div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K inbox-inbox-g-W-hy-aG-K" title="Text color" id="inbox-inbox-+foreColor" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:auto;line-height:28px;padding:0px 5px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-Ig-lc" style="display:inline-block"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-s1-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-mr" style="display:inline-block;color:black"><div class="inbox-inbox-g-hy-aG-K-Gx" style="border-bottom:3px solid rgb(0,0,0);box-sizing:border-box;height:18px"><div class="inbox-inbox-h-N inbox-inbox-h-K2" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px;line-height:18px"></div></div></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-NK" style="display:flex"> </div></div></div></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K inbox-inbox-h-cX inbox-inbox-g-W-GE" title="Font size" id="inbox-inbox-+fontSize" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;line-height:28px;padding:0px 5px;width:auto"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-Ig-lc" style="display:inline-block"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-s1-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-mr" id="inbox-inbox-:nz" style="display:inline-block;color:black;font-size:0px;line-height:0;overflow:hidden;background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px">Normal</div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-NK" style="display:flex"> </div></div></div></div></div></div><div class="inbox-inbox-pQ8uTb"><div class="inbox-inbox-g-W inbox-inbox-g-W-DKlKme" style="display:flex"><div class="inbox-inbox-g-W-Cw inbox-inbox-g-W-Cw-mD inbox-inbox-g-mu-sE" id="inbox-inbox-:no" style="display:inline-block;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;background-color:rgb(229,229,229);height:28px;margin:0px 6px;width:1px"> </div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="More formatting options" id="inbox-inbox-moreFormattingOptions" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-g-W-aG-K-NK" style="display:flex"></div></div></div></div></div></div><div class="inbox-inbox-Mx" style="background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;padding:8px;display:inline-flex"><div class="inbox-inbox-g-W inbox-inbox-g-W-DKlKme" tabindex="-1" style="display:flex"><div class="inbox-inbox-g-W-Cw inbox-inbox-g-W-Cw-mD inbox-inbox-g-mu-sE" id="inbox-inbox-:ob" style="display:inline-block;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;background-color:rgb(229,229,229);height:28px;margin:0px 6px;width:1px"></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K inbox-inbox-h-tS inbox-inbox-g-W-GE" title="Font" id="inbox-inbox-+fontName" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;line-height:28px;padding:0px 5px;width:auto"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-Ig-lc" style="display:inline-block"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-s1-lc" style="display:flex;width:96px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-mr" id="inbox-inbox-:oc" style="display:inline-block;color:black;font-weight:bold;overflow:hidden;text-overflow:ellipsis;white-space:nowrap"></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-NK" style="display:flex"></div></div></div></div></div><div class="inbox-inbox-g-W inbox-inbox-g-W-DKlKme" tabindex="-1" style="display:flex"><div class="inbox-inbox-g-W-Cw inbox-inbox-g-W-Cw-mD inbox-inbox-g-mu-sE" id="inbox-inbox-:oe" style="display:inline-block;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;background-color:rgb(229,229,229);height:28px;margin:0px 6px;width:1px"></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="Bullet list" id="inbox-inbox-+insertUnorderedList" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-h-N inbox-inbox-h-QBb5Bf" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px"></div></div></div></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="Numbered list" id="inbox-inbox-+insertOrderedList" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-h-N inbox-inbox-h-xoUHxd" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px"></div></div></div></div></div><div class="inbox-inbox-g-W inbox-inbox-g-W-DKlKme" tabindex="-1" style="display:flex"><div class="inbox-inbox-g-W-Cw inbox-inbox-g-W-Cw-mD inbox-inbox-g-mu-sE" id="inbox-inbox-:og" style="display:inline-block;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;background-color:rgb(229,229,229);height:28px;margin:0px 6px;width:1px"></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="Add or remove link" id="inbox-inbox-+link" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-h-s" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px;font-size:0px"></div></div></div></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K" title="Remove formatting" id="inbox-inbox-+removeFormat" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:28px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-Ig-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-K-s1-lc" style="display:inline-block"><div class="inbox-inbox-h-N inbox-inbox-h-HV735b" style="background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px"></div></div></div></div></div><div class="inbox-inbox-g-W inbox-inbox-g-W-DKlKme" tabindex="-1" style="display:flex"><div class="inbox-inbox-g-W-Cw inbox-inbox-g-W-Cw-mD inbox-inbox-g-mu-sE" id="inbox-inbox-:or" style="display:inline-block;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial;background-color:rgb(229,229,229);height:28px;margin:0px 6px;width:1px"></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K inbox-inbox-g-W-aZ-bm-aG-K" title="Templates" id="inbox-inbox-:os" tabindex="0" style="display:flex;border-radius:3px;opacity:0.6;height:28px;width:auto;line-height:28px;padding:0px 5px"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-Ig-lc" style="display:inline-block"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-s1-lc" style="display:flex"><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-mr" style="display:inline-block;color:black;font-size:0px;line-height:0;overflow:hidden;background-position:50% 50%;background-repeat:no-repeat;background-size:18px;height:18px;width:18px"><div class="inbox-inbox-h-sBkzoe" style="user-select: none;"></div></div><div class="inbox-inbox-g-mu-sE inbox-inbox-g-W-aG-K-NK" style="display:flex"></div></div></div></div></div></div></div><br class="inbox-inbox-Apple-interchange-newline"></div>
</blockquote></div></div>