<div dir="ltr">Should be fixed by r289449.<div><br></div><div>By the way, it seems really weird that changes to lib/Support should require changes to some other random part of the project. Should this script be checking for the desired property more directly, e.g. by linking a test program and testing that the link succeeds?</div><div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 12, 2016 at 8:31 AM, Mike Aizatsky <span dir="ltr"><<a href="mailto:aizatsky@google.com" target="_blank">aizatsky@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Peter,<div><br></div><div>I think this breaks many bots:</div><div><br></div><div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/368" target="_blank">http://lab.llvm.org:8011/<wbr>builders/sanitizer-x86_64-<wbr>linux/builds/368</a><br></div></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Thu, Dec 8, 2016 at 9:07 PM Peter Collingbourne via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pcc<br class="m_-4131136173857620664gmail_msg">
Date: Thu Dec  8 22:57:19 2016<br class="m_-4131136173857620664gmail_msg">
New Revision: 289184<br class="m_-4131136173857620664gmail_msg">
<br class="m_-4131136173857620664gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289184&view=rev" rel="noreferrer" class="m_-4131136173857620664gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=289184&view=rev</a><br class="m_-4131136173857620664gmail_msg">
Log:<br class="m_-4131136173857620664gmail_msg">
Support: Use a 64-bit seek in raw_fd_ostream::seek().<br class="m_-4131136173857620664gmail_msg">
<br class="m_-4131136173857620664gmail_msg">
Modified:<br class="m_-4131136173857620664gmail_msg">
    llvm/trunk/lib/Support/raw_<wbr>ostream.cpp<br class="m_-4131136173857620664gmail_msg">
<br class="m_-4131136173857620664gmail_msg">
Modified: llvm/trunk/lib/Support/raw_<wbr>ostream.cpp<br class="m_-4131136173857620664gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/raw_ostream.cpp?rev=289184&r1=289183&r2=289184&view=diff" rel="noreferrer" class="m_-4131136173857620664gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Support/raw_ostream.cpp?rev=<wbr>289184&r1=289183&r2=289184&<wbr>view=diff</a><br class="m_-4131136173857620664gmail_msg">
==============================<wbr>==============================<wbr>==================<br class="m_-4131136173857620664gmail_msg">
--- llvm/trunk/lib/Support/raw_<wbr>ostream.cpp (original)<br class="m_-4131136173857620664gmail_msg">
+++ llvm/trunk/lib/Support/raw_<wbr>ostream.cpp Thu Dec  8 22:57:19 2016<br class="m_-4131136173857620664gmail_msg">
@@ -598,7 +598,11 @@ void raw_fd_ostream::close() {<br class="m_-4131136173857620664gmail_msg">
 uint64_t raw_fd_ostream::seek(uint64_t off) {<br class="m_-4131136173857620664gmail_msg">
   assert(SupportsSeeking && "Stream does not support seeking!");<br class="m_-4131136173857620664gmail_msg">
   flush();<br class="m_-4131136173857620664gmail_msg">
-  pos = ::lseek(FD, off, SEEK_SET);<br class="m_-4131136173857620664gmail_msg">
+#ifdef LLVM_ON_WIN32<br class="m_-4131136173857620664gmail_msg">
+  pos = ::_lseeki64(FD, off, SEEK_SET);<br class="m_-4131136173857620664gmail_msg">
+#else<br class="m_-4131136173857620664gmail_msg">
+  pos = ::lseek64(FD, off, SEEK_SET);<br class="m_-4131136173857620664gmail_msg">
+#endif<br class="m_-4131136173857620664gmail_msg">
   if (pos == (uint64_t)-1)<br class="m_-4131136173857620664gmail_msg">
     error_detected();<br class="m_-4131136173857620664gmail_msg">
   return pos;<br class="m_-4131136173857620664gmail_msg">
<br class="m_-4131136173857620664gmail_msg">
<br class="m_-4131136173857620664gmail_msg">
______________________________<wbr>_________________<br class="m_-4131136173857620664gmail_msg">
llvm-commits mailing list<br class="m_-4131136173857620664gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="m_-4131136173857620664gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="m_-4131136173857620664gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_-4131136173857620664gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br class="m_-4131136173857620664gmail_msg">
</blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Mike<br>Sent from phone</div></div>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>