<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 12, 2016 at 3:46 PM Michael Kuperstein <<a href="mailto:mkuper@google.com">mkuper@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">FWIW, while lookup is more common, we already have both spellings:<div class="gmail_msg"><br class="gmail_msg">FastISel::lookUpRegForValue(const Value *V)<br class="gmail_msg">PPCAsmPrinter::lookUpOrCreateTOCEntry(MCSymbol *Sym)<div class="gmail_msg"><pre style="margin-top:0px;margin-bottom:0px;color:rgb(0,0,0);font-size:medium;background-color:rgba(255,255,255,0.901961)" class="gmail_msg"></pre></div></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">And a couple more in the symbolizer.</div></div></blockquote><div><br>Fair point - though, as you say, looks like 'lookup' is far more common (I'd wager an order of magnitude at least, in LLVM/include let alone across all LLVM projects).<br><br>But, yeah.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"></bikeshedding></div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Mon, Dec 12, 2016 at 3:29 PM, David Blaikie via llvm-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">This seems inconsistent with a fair amount of existing precedent in LLVM.<br class="gmail_msg"><br class="gmail_msg">we have loads of functions that use lookup as a verb (DenseMap::lookup, ScopedHashTable::lookup, IntervalMap::lookup, ImmutableMap::lookup, MapVector::lookup - just to name those in ADT, but they're littered across all parts of LLVM)<div class="gmail_msg"><div class="m_-8757435594883414754h5 gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Sat, Dec 3, 2016 at 12:00 PM Justin Lebar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jlebar<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Date: Sat Dec  3 13:49:35 2016<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
New Revision: 288598<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288598&view=rev" rel="noreferrer" class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=288598&view=rev</a><br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Log:<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
[PM] Rename lookupPass to lookUpPass.<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Summary:<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
"Lookup" is a noun ("lookup table"), "look up" is a verb ("look up<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
'table' in the dictionary").<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Reviewers: chandlerc<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Subscribers: silvas, llvm-commits, mehdi_amini<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D27374" rel="noreferrer" class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D27374</a><br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Modified:<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
    llvm/trunk/include/llvm/IR/PassManager.h<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
Modified: llvm/trunk/include/llvm/IR/PassManager.h<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=288598&r1=288597&r2=288598&view=diff" rel="noreferrer" class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=288598&r1=288597&r2=288598&view=diff</a><br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
==============================================================================<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
--- llvm/trunk/include/llvm/IR/PassManager.h (original)<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
+++ llvm/trunk/include/llvm/IR/PassManager.h Sat Dec  3 13:49:35 2016<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
@@ -638,16 +638,16 @@ public:<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
   }<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
 private:<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
-  /// \brief Lookup a registered analysis pass.<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
-  PassConceptT &lookupPass(AnalysisKey *ID) {<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
+  /// \brief Look up a registered analysis pass.<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
+  PassConceptT &lookUpPass(AnalysisKey *ID) {<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     typename AnalysisPassMapT::iterator PI = AnalysisPasses.find(ID);<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     assert(PI != AnalysisPasses.end() &&<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
            "Analysis passes must be registered prior to being queried!");<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     return *PI->second;<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
   }<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
-  /// \brief Lookup a registered analysis pass.<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
-  const PassConceptT &lookupPass(AnalysisKey *ID) const {<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
+  /// \brief Look up a registered analysis pass.<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
+  const PassConceptT &lookUpPass(AnalysisKey *ID) const {<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     typename AnalysisPassMapT::const_iterator PI = AnalysisPasses.find(ID);<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     assert(PI != AnalysisPasses.end() &&<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
            "Analysis passes must be registered prior to being queried!");<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
@@ -665,7 +665,7 @@ private:<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     // If we don't have a cached result for this function, look up the pass and<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     // run it to produce a result, which we then add to the cache.<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     if (Inserted) {<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
-      auto &P = this->lookupPass(ID);<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
+      auto &P = this->lookUpPass(ID);<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
       if (DebugLogging)<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
         dbgs() << "Running analysis: " << P.name() << "\n";<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
       AnalysisResultListT &ResultList = AnalysisResultLists[&IR];<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
@@ -697,7 +697,7 @@ private:<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
       return;<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     if (DebugLogging)<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
-      dbgs() << "Invalidating analysis: " << this->lookupPass(ID).name()<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
+      dbgs() << "Invalidating analysis: " << this->lookUpPass(ID).name()<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
              << "\n";<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     AnalysisResultLists[&IR].erase(RI->second);<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
     AnalysisResults.erase(RI);<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
_______________________________________________<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
llvm-commits mailing list<br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="m_-8757435594883414754m_-1891173154554694614gmail_msg gmail_msg">
</blockquote></div></div></div></div>
<br class="gmail_msg">_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
<br class="gmail_msg"></blockquote></div><br class="gmail_msg"></div>
</blockquote></div></div>