<div dir="ltr">FWIW, while lookup is more common, we already have both spellings:<div><br>FastISel::lookUpRegForValue(const Value *V)<br>PPCAsmPrinter::lookUpOrCreateTOCEntry(MCSymbol *Sym)<div><pre style="margin-top:0px;margin-bottom:0px;color:rgb(0,0,0);font-size:medium;background-color:rgba(255,255,255,0.901961)"></pre></div></div><div><br></div><div>And a couple more in the symbolizer.</div><div><br></div><div></bikeshedding></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 12, 2016 at 3:29 PM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This seems inconsistent with a fair amount of existing precedent in LLVM.<br><br>we have loads of functions that use lookup as a verb (DenseMap::lookup, ScopedHashTable::lookup, IntervalMap::lookup, ImmutableMap::lookup, MapVector::lookup - just to name those in ADT, but they're littered across all parts of LLVM)<div><div class="h5"><br><br><div class="gmail_quote"><div dir="ltr">On Sat, Dec 3, 2016 at 12:00 PM Justin Lebar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jlebar<br class="m_-1891173154554694614gmail_msg">
Date: Sat Dec 3 13:49:35 2016<br class="m_-1891173154554694614gmail_msg">
New Revision: 288598<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288598&view=rev" rel="noreferrer" class="m_-1891173154554694614gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=288598&view=rev</a><br class="m_-1891173154554694614gmail_msg">
Log:<br class="m_-1891173154554694614gmail_msg">
[PM] Rename lookupPass to lookUpPass.<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
Summary:<br class="m_-1891173154554694614gmail_msg">
"Lookup" is a noun ("lookup table"), "look up" is a verb ("look up<br class="m_-1891173154554694614gmail_msg">
'table' in the dictionary").<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
Reviewers: chandlerc<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
Subscribers: silvas, llvm-commits, mehdi_amini<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D27374" rel="noreferrer" class="m_-1891173154554694614gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D27374</a><br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
Modified:<br class="m_-1891173154554694614gmail_msg">
llvm/trunk/include/llvm/IR/<wbr>PassManager.h<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
Modified: llvm/trunk/include/llvm/IR/<wbr>PassManager.h<br class="m_-1891173154554694614gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=288598&r1=288597&r2=288598&view=diff" rel="noreferrer" class="m_-1891173154554694614gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/IR/PassManager.h?rev=<wbr>288598&r1=288597&r2=288598&<wbr>view=diff</a><br class="m_-1891173154554694614gmail_msg">
==============================<wbr>==============================<wbr>==================<br class="m_-1891173154554694614gmail_msg">
--- llvm/trunk/include/llvm/IR/<wbr>PassManager.h (original)<br class="m_-1891173154554694614gmail_msg">
+++ llvm/trunk/include/llvm/IR/<wbr>PassManager.h Sat Dec 3 13:49:35 2016<br class="m_-1891173154554694614gmail_msg">
@@ -638,16 +638,16 @@ public:<br class="m_-1891173154554694614gmail_msg">
}<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
private:<br class="m_-1891173154554694614gmail_msg">
- /// \brief Lookup a registered analysis pass.<br class="m_-1891173154554694614gmail_msg">
- PassConceptT &lookupPass(AnalysisKey *ID) {<br class="m_-1891173154554694614gmail_msg">
+ /// \brief Look up a registered analysis pass.<br class="m_-1891173154554694614gmail_msg">
+ PassConceptT &lookUpPass(AnalysisKey *ID) {<br class="m_-1891173154554694614gmail_msg">
typename AnalysisPassMapT::iterator PI = AnalysisPasses.find(ID);<br class="m_-1891173154554694614gmail_msg">
assert(PI != AnalysisPasses.end() &&<br class="m_-1891173154554694614gmail_msg">
"Analysis passes must be registered prior to being queried!");<br class="m_-1891173154554694614gmail_msg">
return *PI->second;<br class="m_-1891173154554694614gmail_msg">
}<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
- /// \brief Lookup a registered analysis pass.<br class="m_-1891173154554694614gmail_msg">
- const PassConceptT &lookupPass(AnalysisKey *ID) const {<br class="m_-1891173154554694614gmail_msg">
+ /// \brief Look up a registered analysis pass.<br class="m_-1891173154554694614gmail_msg">
+ const PassConceptT &lookUpPass(AnalysisKey *ID) const {<br class="m_-1891173154554694614gmail_msg">
typename AnalysisPassMapT::const_<wbr>iterator PI = AnalysisPasses.find(ID);<br class="m_-1891173154554694614gmail_msg">
assert(PI != AnalysisPasses.end() &&<br class="m_-1891173154554694614gmail_msg">
"Analysis passes must be registered prior to being queried!");<br class="m_-1891173154554694614gmail_msg">
@@ -665,7 +665,7 @@ private:<br class="m_-1891173154554694614gmail_msg">
// If we don't have a cached result for this function, look up the pass and<br class="m_-1891173154554694614gmail_msg">
// run it to produce a result, which we then add to the cache.<br class="m_-1891173154554694614gmail_msg">
if (Inserted) {<br class="m_-1891173154554694614gmail_msg">
- auto &P = this->lookupPass(ID);<br class="m_-1891173154554694614gmail_msg">
+ auto &P = this->lookUpPass(ID);<br class="m_-1891173154554694614gmail_msg">
if (DebugLogging)<br class="m_-1891173154554694614gmail_msg">
dbgs() << "Running analysis: " << P.name() << "\n";<br class="m_-1891173154554694614gmail_msg">
AnalysisResultListT &ResultList = AnalysisResultLists[&IR];<br class="m_-1891173154554694614gmail_msg">
@@ -697,7 +697,7 @@ private:<br class="m_-1891173154554694614gmail_msg">
return;<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
if (DebugLogging)<br class="m_-1891173154554694614gmail_msg">
- dbgs() << "Invalidating analysis: " << this->lookupPass(ID).name()<br class="m_-1891173154554694614gmail_msg">
+ dbgs() << "Invalidating analysis: " << this->lookUpPass(ID).name()<br class="m_-1891173154554694614gmail_msg">
<< "\n";<br class="m_-1891173154554694614gmail_msg">
AnalysisResultLists[&IR].<wbr>erase(RI->second);<br class="m_-1891173154554694614gmail_msg">
AnalysisResults.erase(RI);<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
<br class="m_-1891173154554694614gmail_msg">
______________________________<wbr>_________________<br class="m_-1891173154554694614gmail_msg">
llvm-commits mailing list<br class="m_-1891173154554694614gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="m_-1891173154554694614gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="m_-1891173154554694614gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_-1891173154554694614gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br class="m_-1891173154554694614gmail_msg">
</blockquote></div></div></div></div>
<br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>