<div dir="ltr">This seems inconsistent with a fair amount of existing precedent in LLVM.<br><br>we have loads of functions that use lookup as a verb (DenseMap::lookup, ScopedHashTable::lookup, IntervalMap::lookup, ImmutableMap::lookup, MapVector::lookup - just to name those in ADT, but they're littered across all parts of LLVM)<br><br><div class="gmail_quote"><div dir="ltr">On Sat, Dec 3, 2016 at 12:00 PM Justin Lebar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jlebar<br class="gmail_msg">
Date: Sat Dec  3 13:49:35 2016<br class="gmail_msg">
New Revision: 288598<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288598&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=288598&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[PM] Rename lookupPass to lookUpPass.<br class="gmail_msg">
<br class="gmail_msg">
Summary:<br class="gmail_msg">
"Lookup" is a noun ("lookup table"), "look up" is a verb ("look up<br class="gmail_msg">
'table' in the dictionary").<br class="gmail_msg">
<br class="gmail_msg">
Reviewers: chandlerc<br class="gmail_msg">
<br class="gmail_msg">
Subscribers: silvas, llvm-commits, mehdi_amini<br class="gmail_msg">
<br class="gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D27374" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27374</a><br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/include/llvm/IR/PassManager.h<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/include/llvm/IR/PassManager.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=288598&r1=288597&r2=288598&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=288598&r1=288597&r2=288598&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/include/llvm/IR/PassManager.h (original)<br class="gmail_msg">
+++ llvm/trunk/include/llvm/IR/PassManager.h Sat Dec  3 13:49:35 2016<br class="gmail_msg">
@@ -638,16 +638,16 @@ public:<br class="gmail_msg">
   }<br class="gmail_msg">
<br class="gmail_msg">
 private:<br class="gmail_msg">
-  /// \brief Lookup a registered analysis pass.<br class="gmail_msg">
-  PassConceptT &lookupPass(AnalysisKey *ID) {<br class="gmail_msg">
+  /// \brief Look up a registered analysis pass.<br class="gmail_msg">
+  PassConceptT &lookUpPass(AnalysisKey *ID) {<br class="gmail_msg">
     typename AnalysisPassMapT::iterator PI = AnalysisPasses.find(ID);<br class="gmail_msg">
     assert(PI != AnalysisPasses.end() &&<br class="gmail_msg">
            "Analysis passes must be registered prior to being queried!");<br class="gmail_msg">
     return *PI->second;<br class="gmail_msg">
   }<br class="gmail_msg">
<br class="gmail_msg">
-  /// \brief Lookup a registered analysis pass.<br class="gmail_msg">
-  const PassConceptT &lookupPass(AnalysisKey *ID) const {<br class="gmail_msg">
+  /// \brief Look up a registered analysis pass.<br class="gmail_msg">
+  const PassConceptT &lookUpPass(AnalysisKey *ID) const {<br class="gmail_msg">
     typename AnalysisPassMapT::const_iterator PI = AnalysisPasses.find(ID);<br class="gmail_msg">
     assert(PI != AnalysisPasses.end() &&<br class="gmail_msg">
            "Analysis passes must be registered prior to being queried!");<br class="gmail_msg">
@@ -665,7 +665,7 @@ private:<br class="gmail_msg">
     // If we don't have a cached result for this function, look up the pass and<br class="gmail_msg">
     // run it to produce a result, which we then add to the cache.<br class="gmail_msg">
     if (Inserted) {<br class="gmail_msg">
-      auto &P = this->lookupPass(ID);<br class="gmail_msg">
+      auto &P = this->lookUpPass(ID);<br class="gmail_msg">
       if (DebugLogging)<br class="gmail_msg">
         dbgs() << "Running analysis: " << P.name() << "\n";<br class="gmail_msg">
       AnalysisResultListT &ResultList = AnalysisResultLists[&IR];<br class="gmail_msg">
@@ -697,7 +697,7 @@ private:<br class="gmail_msg">
       return;<br class="gmail_msg">
<br class="gmail_msg">
     if (DebugLogging)<br class="gmail_msg">
-      dbgs() << "Invalidating analysis: " << this->lookupPass(ID).name()<br class="gmail_msg">
+      dbgs() << "Invalidating analysis: " << this->lookUpPass(ID).name()<br class="gmail_msg">
              << "\n";<br class="gmail_msg">
     AnalysisResultLists[&IR].erase(RI->second);<br class="gmail_msg">
     AnalysisResults.erase(RI);<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>