<div dir="ltr">Nice catch, updated in r289346</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Dec 11, 2016 at 9:39 AM, Roel Jordans via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I guess you would also want to update the comment here?<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On 10-12-16 12:18, Dylan McKay via llvm-commits wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: dylanmckay<br>
Date: Sat Dec 10 05:18:37 2016<br>
New Revision: 289323<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=289323&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=289323&view=rev</a><br>
Log:<br>
[AVR] Fix an inline asm assertion which would always trigger<br>
<br>
It looks like some time in the past, constraint codes were changed from<br>
chars being passed around to enums.<br>
<br>
Modified:<br>
     llvm/trunk/lib/Target/AVR/AVR<wbr>ISelDAGToDAG.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/AVR/AVRI<wbr>SelDAGToDAG.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AVR/AVRISelDAGToDAG.cpp?rev=289323&r1=289322&r2=289323&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Target/AV<wbr>R/AVRISelDAGToDAG.cpp?rev=2893<wbr>23&r1=289322&r2=289323&view=<wbr>diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/AVR/AVRI<wbr>SelDAGToDAG.cpp (original)<br>
+++ llvm/trunk/lib/Target/AVR/AVRI<wbr>SelDAGToDAG.cpp Sat Dec 10 05:18:37 2016<br>
@@ -205,7 +205,7 @@ bool AVRDAGToDAGISel::SelectInlineA<wbr>smMem<br>
                                                     std::vector<SDValue> &OutOps) {<br>
    // Yes hardcoded 'm' symbol. Just because it also has been hardcoded in<br>
    // SelectionDAGISel (callee for this method).<br>
-  assert(ConstraintCode == 'm' && "Unexpected asm memory constraint");<br>
+  assert(ConstraintCode == InlineAsm::Constraint_m && "Unexpected asm memory constraint");<br>
      MachineRegisterInfo &RI = MF->getRegInfo();<br>
    const AVRSubtarget &STI = MF->getSubtarget<AVRSubtarget><wbr>();<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>