<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 7, 2016 at 2:14 AM Philip Reames via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: reames<br class="gmail_msg">
Date: Tue Dec 6 19:03:56 2016<br class="gmail_msg">
New Revision: 288874<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288874&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=288874&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[LVI] Remove used return value from markX functions<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/lib/Analysis/LazyValueInfo.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Analysis/LazyValueInfo.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=288874&r1=288873&r2=288874&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=288874&r1=288873&r2=288874&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Analysis/LazyValueInfo.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp Tue Dec 6 19:03:56 2016<br class="gmail_msg">
@@ -141,37 +141,36 @@ public:<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
private:<br class="gmail_msg">
- /// Return true if this is a change in status.<br class="gmail_msg">
- bool markOverdefined() {<br class="gmail_msg">
+ void markOverdefined() {<br class="gmail_msg">
if (isOverdefined())<br class="gmail_msg">
- return false;<br class="gmail_msg">
+ return;<br class="gmail_msg">
Tag = overdefined;<br class="gmail_msg">
- return true;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- /// Return true if this is a change in status.<br class="gmail_msg">
- bool markConstant(Constant *V) {<br class="gmail_msg">
+ void markConstant(Constant *V) {<br class="gmail_msg">
assert(V && "Marking constant with NULL");<br class="gmail_msg">
- if (ConstantInt *CI = dyn_cast<ConstantInt>(V))<br class="gmail_msg">
- return markConstantRange(ConstantRange(CI->getValue()));<br class="gmail_msg">
+ if (ConstantInt *CI = dyn_cast<ConstantInt>(V)) {<br class="gmail_msg">
+ markConstantRange(ConstantRange(CI->getValue()));<br class="gmail_msg">
+ return;<br class="gmail_msg">
+ }<br class="gmail_msg">
if (isa<UndefValue>(V))<br class="gmail_msg">
- return false;<br class="gmail_msg">
+ return;<br class="gmail_msg">
<br class="gmail_msg">
assert((!isConstant() || getConstant() == V) &&<br class="gmail_msg">
"Marking constant with different value");<br class="gmail_msg">
assert(isUndefined());<br class="gmail_msg">
Tag = constant;<br class="gmail_msg">
Val = V;<br class="gmail_msg">
- return true;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- /// Return true if this is a change in status.<br class="gmail_msg">
- bool markNotConstant(Constant *V) {<br class="gmail_msg">
+ void markNotConstant(Constant *V) {<br class="gmail_msg">
assert(V && "Marking constant with NULL");<br class="gmail_msg">
- if (ConstantInt *CI = dyn_cast<ConstantInt>(V))<br class="gmail_msg">
- return markConstantRange(ConstantRange(CI->getValue()+1, CI->getValue()));<br class="gmail_msg">
+ if (ConstantInt *CI = dyn_cast<ConstantInt>(V)) {<br class="gmail_msg">
+ markConstantRange(ConstantRange(CI->getValue()+1, CI->getValue()));<br class="gmail_msg">
+ return;<br class="gmail_msg">
+ }<br class="gmail_msg">
if (isa<UndefValue>(V))<br class="gmail_msg">
- return false;<br class="gmail_msg">
+ return;<br class="gmail_msg">
<br class="gmail_msg">
assert((!isConstant() || getConstant() != V) &&<br class="gmail_msg">
"Marking constant !constant with same value");<br class="gmail_msg">
@@ -180,27 +179,26 @@ private:<br class="gmail_msg">
assert(isUndefined() || isConstant());<br class="gmail_msg">
Tag = notconstant;<br class="gmail_msg">
Val = V;<br class="gmail_msg">
- return true;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- /// Return true if this is a change in status.<br class="gmail_msg">
- bool markConstantRange(ConstantRange NewR) {<br class="gmail_msg">
+ void markConstantRange(ConstantRange NewR) {<br class="gmail_msg">
if (isConstantRange()) {<br class="gmail_msg">
if (NewR.isEmptySet())<br class="gmail_msg">
- return markOverdefined();<br class="gmail_msg">
-<br class="gmail_msg">
- bool changed = Range != NewR;<br class="gmail_msg">
- Range = std::move(NewR);<br class="gmail_msg">
- return changed;<br class="gmail_msg">
+ markOverdefined();<br class="gmail_msg">
+ else {<br class="gmail_msg">
+ bool changed = Range != NewR;<br class="gmail_msg"></blockquote><div><br></div><div>I now get:</div><div><br></div><div><div>../lib/Analysis/LazyValueInfo.cpp:189:14: warning: unused variable 'changed' [-Wunused-variable]</div><div> bool changed = Range != NewR;</div><div> ^</div></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ Range = std::move(NewR);<br class="gmail_msg">
+ }<br class="gmail_msg">
+ return;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
assert(isUndefined());<br class="gmail_msg">
if (NewR.isEmptySet())<br class="gmail_msg">
- return markOverdefined();<br class="gmail_msg">
-<br class="gmail_msg">
- Tag = constantrange;<br class="gmail_msg">
- Range = std::move(NewR);<br class="gmail_msg">
- return true;<br class="gmail_msg">
+ markOverdefined();<br class="gmail_msg">
+ else {<br class="gmail_msg">
+ Tag = constantrange;<br class="gmail_msg">
+ Range = std::move(NewR);<br class="gmail_msg">
+ }<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
public:<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div>