<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Why not simply change<div class=""><br class=""></div><div class="">#if defined (__APPLE__) && HAVE_CRASHREPORTERCLIENT_H</div><div class="">to</div><div class="">#if define (__APPLE__) && defined(HAVE_CRASHREPORTERCLIENT_H)</div><div class=""><br class=""></div><div class="">in PrettyStackTrace.cpp?</div><div class=""><br class=""></div><div class="">In my experience relying on 0/1 does not work because people like to write</div><div class="">#ifdef/#ifndef and will be very surprised that #ifdef BLA works even if BLA is zero...</div><div class=""><br class=""></div><div class="">- Matthias</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 7, 2016, at 1:05 PM, Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yes, I had a followup patch that fixes it.<div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Dec 7, 2016, at 12:43 PM, Mike Aizatsky <<a href="mailto:aizatsky@google.com" class="">aizatsky@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Chris,<div class=""><br class=""></div><div class="">I think this breaks the bot:</div><div class=""><br class=""></div><div class=""><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/1219/steps/build%20clang%2Fmsan/logs/stdio" class="">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/1219/steps/build%20clang%2Fmsan/logs/stdio</a><br class=""></div><div class=""><br class=""></div><div class=""><div class="">FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/PrettyStackTrace.cpp.o </div><div class="">/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Support -Iinclude -I/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/include -nostdinc++ -isystem /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include -isystem /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1 -lc++abi -Wl,--rpath=/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/lib -L/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/lib -fsanitize=memory -w -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Werror=date-time -std=c++11 -fno-omit-frame-pointer -gline-tables-only -fsanitize=memory -fcolor-diagnostics -ffunction-sections -fdata-sections -O3 -UNDEBUG -fno-exceptions -fno-rtti -MMD -MT lib/Support/CMakeFiles/LLVMSupport.dir/PrettyStackTrace.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/PrettyStackTrace.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/PrettyStackTrace.cpp.o -c /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Support/PrettyStackTrace.cpp</div><div class="">/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/lib/Support/PrettyStackTrace.cpp:27:10: fatal error: 'CrashReporterClient.h' file not found</div><div class="">#include <CrashReporterClient.h></div><div class=""> ^~~~~~~~~~~~~~~~~~~~~~~</div><div class="">1 error generated.</div></div><div class=""><br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Dec 7, 2016 at 11:23 AM Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: cbieneman<br class="gmail_msg">
Date: Wed Dec 7 13:13:32 2016<br class="gmail_msg">
New Revision: 288959<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288959&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=288959&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[CMake] Use cmakedefine01 instead of cmakedefine<br class="gmail_msg">
<br class="gmail_msg">
Looks like we need a 01 value for HAVE_CRASHREPORTERCLIENT_H.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/include/llvm/Config/config.h.cmake<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/include/llvm/Config/config.h.cmake<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Config/config.h.cmake?rev=288959&r1=288958&r2=288959&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Config/config.h.cmake?rev=288959&r1=288958&r2=288959&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/include/llvm/Config/config.h.cmake (original)<br class="gmail_msg">
+++ llvm/trunk/include/llvm/Config/config.h.cmake Wed Dec 7 13:13:32 2016<br class="gmail_msg">
@@ -17,7 +17,7 @@<br class="gmail_msg">
#cmakedefine HAVE_BACKTRACE ${HAVE_BACKTRACE}<br class="gmail_msg">
<br class="gmail_msg">
/* Define to 1 if you have the <CrashReporterClient.h> header file. */<br class="gmail_msg">
-#cmakedefine HAVE_CRASHREPORTERCLIENT_H<br class="gmail_msg">
+#cmakedefine01 HAVE_CRASHREPORTERCLIENT_H<br class="gmail_msg">
<br class="gmail_msg">
/* can use __crashreporter_info__ */<br class="gmail_msg">
#undef HAVE_CRASHREPORTER_INFO<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div><div dir="ltr" class="">-- <br class=""></div><div data-smartmail="gmail_signature" class=""><div dir="ltr" class="">Mike<br class="">Sent from phone</div></div>
</div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>