<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p>Yes.  I'm pretty sure I know which change and will reintroduce
      the check I removed.  However, if someone could extract a IR test
      case which triggers this, I'd appreciate it.  I don't keep a
      prebuilt copy of clang around and it looks like only the clang
      tests catch this.  I'd like to understand how exactly we got here.</p>
    <p>Philip<br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 12/06/2016 08:29 PM, Peter
      Collingbourne wrote:<br>
    </div>
    <blockquote
cite="mid:CAPQLkRjnT7updDz9t8jP6vFQjjFUBbEPV4CWpmZ5E6JcfKZgHg@mail.gmail.com"
      type="cite">
      <div dir="auto">Hi Philip,
        <div dir="auto"><br>
        </div>
        <div dir="auto">One of our chromium bots has started failing
          with an assertion failure in LVI.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto"><a moz-do-not-send="true"
href="https://build.chromium.org/p/chromium.fyi/builders/ThinLTO%20Linux%20ToT/builds/635/steps/compile/logs/stdio">https://build.chromium.org/p/chromium.fyi/builders/ThinLTO%20Linux%20ToT/builds/635/steps/compile/logs/stdio</a><br>
        </div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">Could it be possible that one of your recent
          changes has caused this?</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">I'll see if I can get you a reproducer if you
          can't figure it out.</div>
        <div dir="auto"><br>
        </div>
        <div dir="auto">Peter</div>
        <div dir="auto"><br>
        </div>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Dec 6, 2016 20:21, "Philip Reames
          via llvm-commits" <<a moz-do-not-send="true"
            href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>>
          wrote:<br type="attribution">
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
            reames<br>
            Date: Tue Dec  6 22:11:22 2016<br>
            New Revision: 288884<br>
            <br>
            URL: <a moz-do-not-send="true"
              href="http://llvm.org/viewvc/llvm-project?rev=288884&view=rev"
              rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=288884&view=rev</a><br>
            Log:<br>
            Fix a warning introduced in r288874<br>
            <br>
            <br>
            Modified:<br>
                llvm/trunk/lib/Analysis/<wbr>LazyValueInfo.cpp<br>
            <br>
            Modified: llvm/trunk/lib/Analysis/<wbr>LazyValueInfo.cpp<br>
            URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=288884&r1=288883&r2=288884&view=diff"
              rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Analysis/LazyValueInfo.cpp?<wbr>rev=288884&r1=288883&r2=<wbr>288884&view=diff</a><br>
            ==============================<wbr>==============================<wbr>==================<br>
            --- llvm/trunk/lib/Analysis/<wbr>LazyValueInfo.cpp
            (original)<br>
            +++ llvm/trunk/lib/Analysis/<wbr>LazyValueInfo.cpp Tue Dec 
            6 22:11:22 2016<br>
            @@ -186,7 +186,6 @@ private:<br>
                   if (NewR.isEmptySet())<br>
                     markOverdefined();<br>
                   else {<br>
            -        bool changed = Range != NewR;<br>
                     Range = std::move(NewR);<br>
                   }<br>
                   return;<br>
            <br>
            <br>
            ______________________________<wbr>_________________<br>
            llvm-commits mailing list<br>
            <a moz-do-not-send="true"
              href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
            <a moz-do-not-send="true"
              href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
              rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>