<div dir="ltr">Weird - wouldn't that have caused a failure at link time due to missing symbols?</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 28, 2016 at 10:14 AM Evgeny Leviant <<a href="mailto:eleviant@accesssoftek.com">eleviant@accesssoftek.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">




<div dir="ltr" style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif" class="gmail_msg">
<p class="gmail_msg">They are defined in InputSection.h since r287787. They didn't have explicit instantiations initialy which, I guess, is because they weren't used anywhere, except InputSection.cpp.<br class="gmail_msg">
</p>
<div style="color:rgb(33,33,33)" class="gmail_msg">
<hr style="display:inline-block;width:98%" class="gmail_msg">
<div id="m_-908758825788748980divRplyFwdMsg" dir="ltr" class="gmail_msg"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt" class="gmail_msg"><b class="gmail_msg">От:</b> David Blaikie <<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>><br class="gmail_msg">
<b class="gmail_msg">Отправлено:</b> 28 ноября 2016 г. 20:48<br class="gmail_msg">
<b class="gmail_msg">Кому:</b> Evgeny Leviant; <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<b class="gmail_msg">Тема:</b> Re: [lld] r287938 - [ELF] Add explicit template instantiations for toString</font>
<div class="gmail_msg"> </div>
</div></div></div><div dir="ltr" style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif" class="gmail_msg"><div style="color:rgb(33,33,33)" class="gmail_msg">
<div class="gmail_msg">
<div dir="ltr" class="gmail_msg">Are there extern template declarations in a header somewhere? (usually I'd expect to see them committed as a matched pair)</div>
<br class="gmail_msg">
<div class="gmail_quote gmail_msg">
<div dir="ltr" class="gmail_msg">On Fri, Nov 25, 2016 at 8:52 AM Eugene Leviant via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
</div>
<blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: evgeny777<br class="gmail_msg">
Date: Fri Nov 25 10:42:04 2016<br class="gmail_msg">
New Revision: 287938<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=287938&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=287938&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[ELF] Add explicit template instantiations for toString<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    lld/trunk/ELF/InputSection.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: lld/trunk/ELF/InputSection.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.cpp?rev=287938&r1=287937&r2=287938&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">
http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.cpp?rev=287938&r1=287937&r2=287938&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lld/trunk/ELF/InputSection.cpp (original)<br class="gmail_msg">
+++ lld/trunk/ELF/InputSection.cpp Fri Nov 25 10:42:04 2016<br class="gmail_msg">
@@ -823,3 +823,8 @@ template class elf::MergeInputSection<EL<br class="gmail_msg">
 template class elf::MergeInputSection<ELF32BE>;<br class="gmail_msg">
 template class elf::MergeInputSection<ELF64LE>;<br class="gmail_msg">
 template class elf::MergeInputSection<ELF64BE>;<br class="gmail_msg">
+<br class="gmail_msg">
+template std::string elf::toString(const InputSectionBase<ELF32LE> *);<br class="gmail_msg">
+template std::string elf::toString(const InputSectionBase<ELF32BE> *);<br class="gmail_msg">
+template std::string elf::toString(const InputSectionBase<ELF64LE> *);<br class="gmail_msg">
+template std::string elf::toString(const InputSectionBase<ELF64BE> *);<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote>
</div>
</div>
</div></div></blockquote></div>