<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 23, 2016 at 11:56 AM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">On Wed, Nov 23, 2016 at 11:53 AM, Rui Ueyama via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> On Wed, Nov 23, 2016 at 11:16 AM, Rafael Espindola via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: rafael<br>
>> Date: Wed Nov 23 13:16:20 2016<br>
>> New Revision: 287799<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=287799&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=287799&view=rev</a><br>
>> Log:<br>
>> Fix this on 32 bit hosts.<br>
>><br>
>> Looks like we have no 32 bit bot that builds with mips support.<br>
>><br>
>> Modified:<br>
>>     lld/trunk/ELF/<wbr>SyntheticSections.cpp<br>
>><br>
>> Modified: lld/trunk/ELF/<wbr>SyntheticSections.cpp<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=287799&r1=287798&r2=287799&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/<wbr>SyntheticSections.cpp?rev=<wbr>287799&r1=287798&r2=287799&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lld/trunk/ELF/<wbr>SyntheticSections.cpp (original)<br>
>> +++ lld/trunk/ELF/<wbr>SyntheticSections.cpp Wed Nov 23 13:16:20 2016<br>
>> @@ -178,7 +178,7 @@ template <class ELFT> void MipsOptionsSe<br>
>><br>
>>    if (!Config->Relocatable)<br>
>>      Reginfo.ri_gp_value = In<ELFT>::MipsGot->getVA() + MipsGPOffset;<br>
>> -  memcpy(Buf + sizeof(Options), &Reginfo, sizeof(Reginfo));<br>
>> +  memcpy(Buf + sizeof(typename ELFT::uint), &Reginfo, sizeof(Reginfo));<br>
><br>
><br>
> Probably sizeof(*Options) is better.<br>
><br>
<br>
</div></div>-1. I personally prefer to be explicit.<br></blockquote><div><br></div><div>I think Rui is right in this case. We are trying to skip over a Elf_Mips_Options object. sizeof(*Options) guarantees that is correct (*Options is literally the object being skipped over, so it better be right!).</div><div>At the very least, this should be changed to sizeof(Elf_Mips_Options) I think. I don't see how ELFT::uint makes sense here.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-HOEnZb"><font color="#888888"><br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span><div class="gmail-HOEnZb"><div class="gmail-h5">______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>