<div dir="ltr">lgtm</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 23, 2016 at 2:40 PM Malcolm Parsons <<a href="mailto:malcolm.parsons@gmail.com">malcolm.parsons@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">malcolm.parsons created this revision.<br class="gmail_msg">
malcolm.parsons added reviewers: beanz, zturner.<br class="gmail_msg">
malcolm.parsons added a subscriber: llvm-commits.<br class="gmail_msg">
<br class="gmail_msg">
The default constructor for a StringRef stores an empty string.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D27067" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27067</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  include/llvm/Support/CommandLine.h<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Index: include/llvm/Support/CommandLine.h<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- include/llvm/Support/CommandLine.h<br class="gmail_msg">
+++ include/llvm/Support/CommandLine.h<br class="gmail_msg">
@@ -179,8 +179,8 @@<br class="gmail_msg">
 //<br class="gmail_msg">
 class SubCommand {<br class="gmail_msg">
 private:<br class="gmail_msg">
-  StringRef Name = "";<br class="gmail_msg">
-  StringRef Description = "";<br class="gmail_msg">
+  StringRef Name;<br class="gmail_msg">
+  StringRef Description;<br class="gmail_msg">
<br class="gmail_msg">
 protected:<br class="gmail_msg">
   void registerSubCommand();<br class="gmail_msg">
@@ -304,8 +304,8 @@<br class="gmail_msg">
                   enum OptionHidden Hidden)<br class="gmail_msg">
       : NumOccurrences(0), Occurrences(OccurrencesFlag), Value(0),<br class="gmail_msg">
         HiddenFlag(Hidden), Formatting(NormalFormatting), Misc(0), Position(0),<br class="gmail_msg">
-        AdditionalVals(0), ArgStr(""), HelpStr(""), ValueStr(""),<br class="gmail_msg">
-        Category(&GeneralCategory), FullyInitialized(false) {}<br class="gmail_msg">
+        AdditionalVals(0), Category(&GeneralCategory), FullyInitialized(false) {<br class="gmail_msg">
+  }<br class="gmail_msg">
<br class="gmail_msg">
   inline void setNumAdditionalVals(unsigned n) { AdditionalVals = n; }<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>