This is not okay. You need to respond to objections *before* you commit. Please revert.<br><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 22, 2016, 11:47 AM Shoaib Meenai <<a href="mailto:smeenai@fb.com">smeenai@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
Closed by commit rL287684: [Triple] Add Facebook vendor (authored by smeenai).<br class="gmail_msg">
<br class="gmail_msg">
Changed prior to commit:<br class="gmail_msg">
  <a href="https://reviews.llvm.org/D25136?vs=73153&id=78910#toc" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25136?vs=73153&id=78910#toc</a><br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D25136" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25136</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  llvm/trunk/include/llvm/ADT/Triple.h<br class="gmail_msg">
  llvm/trunk/lib/Support/Triple.cpp<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Index: llvm/trunk/include/llvm/ADT/Triple.h<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- llvm/trunk/include/llvm/ADT/Triple.h<br class="gmail_msg">
+++ llvm/trunk/include/llvm/ADT/Triple.h<br class="gmail_msg">
@@ -130,6 +130,7 @@<br class="gmail_msg">
     SCEI,<br class="gmail_msg">
     BGP,<br class="gmail_msg">
     BGQ,<br class="gmail_msg">
+    Facebook,<br class="gmail_msg">
     Freescale,<br class="gmail_msg">
     IBM,<br class="gmail_msg">
     ImaginationTechnologies,<br class="gmail_msg">
Index: llvm/trunk/lib/Support/Triple.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Support/Triple.cpp<br class="gmail_msg">
+++ llvm/trunk/lib/Support/Triple.cpp<br class="gmail_msg">
@@ -152,6 +152,7 @@<br class="gmail_msg">
   case SCEI: return "scei";<br class="gmail_msg">
   case BGP: return "bgp";<br class="gmail_msg">
   case BGQ: return "bgq";<br class="gmail_msg">
+  case Facebook: return "facebook";<br class="gmail_msg">
   case Freescale: return "fsl";<br class="gmail_msg">
   case IBM: return "ibm";<br class="gmail_msg">
   case ImaginationTechnologies: return "img";<br class="gmail_msg">
@@ -434,6 +435,7 @@<br class="gmail_msg">
     .Case("scei", Triple::SCEI)<br class="gmail_msg">
     .Case("bgp", Triple::BGP)<br class="gmail_msg">
     .Case("bgq", Triple::BGQ)<br class="gmail_msg">
+    .Case("facebook", Triple::Facebook)<br class="gmail_msg">
     .Case("fsl", Triple::Freescale)<br class="gmail_msg">
     .Case("ibm", Triple::IBM)<br class="gmail_msg">
     .Case("img", Triple::ImaginationTechnologies)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>