<html><head></head><body>I am against reverting it.<br>
<br>
The gold feature is clearly incomplete. It is also dependent on how<br>
sections are named, which is a bad design for ELF and incompatible with<br>
-fno-unique-section-names.<br>
<br>
We can add the gold feature if we really want to, but using symbol names<br>
is actually far more flexible.<br>
<br>
Cheers,<br>
Rafael<br><br><div class="gmail_quote">On November 19, 2016 1:24:26 PM EST, Rui Ueyama <ruiu@google.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div dir="ltr"><div class="gmail_extra">Well, if I knew it was a completely new feature, I didn't LGTM on this patch. It needs a strong justification to add a new feature, and even if we agree with a need of a feature, we still have to discuss what is the best way of doing it. I think if gold already has a similar feature, we should implement that, instead of inventing our own.</div><div class="gmail_extra"><br /></div><div class="gmail_extra">We probably should revert this now, and restart from a proposal and discussion.</div><div class="gmail_extra"><br /><div class="gmail_quote">On Fri, Nov 18, 2016 at 11:15 PM, George Rimar <span dir="ltr"><<a href="mailto:grimar@accesssoftek.com" target="_blank">grimar@accesssoftek.com</a>></span> wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr" style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif"><span class="">
<p><span style="color:rgb(33,33,33);font-size:12pt">>Until now, I was thinking that --symbol-ordering-file is a feature that ld.gold has, but looks like ld.gold doesn't have one. gold has --section-ordering-file instead. >Where does this --symbol-ordering-file
feature come from?</span><br />
</p>
<p><br />
</p>
</span><p>Yes, that is true. Reason to do that was that symbol ordering file allows<br />
</p>
<p>to map symbols to sections with the same name like .text and reorder them. Sections ordering file does not allow to <br />
</p>
<p>do that.<span class="HOEnZb"><font color="#888888"><br />
</font></span></p><span class="HOEnZb"><font color="#888888">
</font><p><font color="#888888"><br />
</font></p>
<p>George.</p></span></div></blockquote></div></div></div>
</blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>