<div dir="ltr">I looked at a couple, and they actually don't specify a triple - which means they expect to run with the host triple.<div>I think expecting to be able to target the host is reasonable behavior, so this is probably fine.</div><div><br></div><div>Sorry for the noise!</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 18, 2016 at 6:54 PM, Dylan McKay <span dir="ltr"><<a href="mailto:dylanmckay34@gmail.com" target="_blank">dylanmckay34@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, here's some of the tests that failed<div><br></div><div><ol style="color:rgb(51,51,51);font-family:verdana,sans-serif;font-size:10px"><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2002-04-14-UnexpectedUnsignedType.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2002-04-14-<wbr>UnexpectedUnsignedType.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-05-27-phifcmpd.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-05-27-phifcmpd.ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2002-04-16-StackFrameSizeAlignment.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2002-04-16-<wbr>StackFrameSizeAlignment.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-05-27-useboolinotherbb.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-05-27-<wbr>useboolinotherbb.ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-05-27-usefsubasbool.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-05-27-<wbr>usefsubasbool.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-05-28-ManyArgs.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-05-28-ManyArgs.ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-05-30-BadFoldGEP.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-05-30-BadFoldGEP.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-05-30-BadPreselectPhi.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-05-30-<wbr>BadPreselectPhi.ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-07-06-BadIntCmp.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-07-06-BadIntCmp.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-07-07-BadLongConst.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-07-07-BadLongConst.<wbr>ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-07-08-BadCastToBool.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-07-08-<wbr>BadCastToBool.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2004-05-09-LiveVarPartialRegister.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2004-05-09-<wbr>LiveVarPartialRegister.ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2003-07-29-BadConstSbyte.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2003-07-29-<wbr>BadConstSbyte.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2005-04-09-GlobalInPHI.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2005-04-09-GlobalInPHI.<wbr>ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2005-01-18-SetUO-InfLoop.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2005-01-18-SetUO-<wbr>InfLoop.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2005-10-21-longlonggtu.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2005-10-21-longlonggtu.<wbr>ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2005-10-18-ZeroSizeStackObject.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2005-10-18-<wbr>ZeroSizeStackObject.ll</a></li><li class="m_2342416228426955492gmail-" style="padding:0.1em 1em"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2005-12-01-Crash.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2005-12-01-Crash.ll</a></li><li class="m_2342416228426955492gmail-alt" style="padding:0.1em 1em;background-color:rgb(246,246,246)"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3A2005-12-12-ExpandSextInreg.ll" style="color:rgb(68,68,68)" target="_blank">FAIL: LLVM::2005-12-12-<wbr>ExpandSextInreg.ll</a><br></li></ol></div><div class="gmail_extra"><br><div class="gmail_quote"><a href="http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-avr-linux/<wbr>builds/2</a><br></div><div class="gmail_quote"><br></div><div class="gmail_quote">The errors tend to look like</div><div class="gmail_quote"><pre style="font-family:"courier new",courier,monotype,monospace;color:rgb(0,0,0);font-size:medium"><span class="m_2342416228426955492gmail-stdout">error: unable to get target for 'x86_64-unknown-linux-gnu'</span></pre>And at least some of the tests are in the llvm/test/CodeGen/Generic directory</div><div><div class="h5"><div class="gmail_quote"><br></div><div class="gmail_quote">On Sat, Nov 19, 2016 at 3:47 PM, Michael Kuperstein <span dir="ltr"><<a href="mailto:mkuper@google.com" target="_blank">mkuper@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This doesn't look right. I may be wrong, but AFAIK, we shouldn't have generic tests that depend on a specific backend.<div><br></div><div>Are those tests that have an X86 triple that live in a non-X86 specific directory?</div><div><div class="m_2342416228426955492gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 18, 2016 at 5:39 PM, Dylan McKay via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: dylanmckay<br>
Date: Fri Nov 18 19:39:07 2016<br>
New Revision: 287418<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=287418&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=287418&view=rev</a><br>
Log:<br>
[AVR] Compile the X86 backend on the AVR builder<br>
<br>
There were a bunch of generic CodeGen tests which required that the X86<br>
backend is included.<br>
<br>
Modified:<br>
zorg/trunk/buildbot/osuosl/mas<wbr>ter/config/builders.py<br>
<br>
Modified: zorg/trunk/buildbot/osuosl/mas<wbr>ter/config/builders.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/buildbot/osuosl/master/config/builders.py?rev=287418&r1=287417&r2=287418&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/zorg/trunk/buildbot/osuo<wbr>sl/master/config/builders.py?r<wbr>ev=287418&r1=287417&r2=287418&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- zorg/trunk/buildbot/osuosl/mas<wbr>ter/config/builders.py (original)<br>
+++ zorg/trunk/buildbot/osuosl/mas<wbr>ter/config/builders.py Fri Nov 18 19:39:07 2016<br>
@@ -81,7 +81,8 @@ def _get_llvm_builders():<br>
extra_cmake_args=[<br>
"-G", "Unix Makefiles",<br>
"-DCMAKE_BUILD_TYPE:STRING=Re<wbr>lease",<br>
- "-DLLVM_TARGETS_TO_BUILD:STRIN<wbr>G=AVR",<br>
+ # We need to compile the X86 backend due to a few generic CodeGen tests.<br>
+ "-DLLVM_TARGETS_TO_BUILD:STRIN<wbr>G=AVR;X86",<br>
"-DLLVM_EXPERIMENTAL_TARGETS_<wbr>TO_BUILD:STRING=AVR",<br>
])}<br>
]<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>