<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 17, 2016 at 2:25 PM, Piotr Padlewski <span dir="ltr"><<a href="mailto:piotr.padlewski@gmail.com" target="_blank">piotr.padlewski@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Prazek added inline comments.<br>
<br>
<br>
================<br>
Comment at: include/llvm/Transforms/<wbr>Scalar/GVNExpression.h:37<br>
+  ExpressionTypeBasicStart,<br>
+  ExpressionTypeBasic,<br>
+  ExpressionTypeCall,<br>
----------------<br>
I am not really sure what does it mean, where other enums seems to be self descriptive.<br>
Does it mean "inside basic block, but not BB start nor end?"<br></blockquote><div><br>Start is just so you can do >start   <end for the enums :)<br></div><div>It doesn't mean anything.</div><div><br></div><div><br></div><div>Basic is just "a random operation with operands"</div><div>Better names welcome :)</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<br>
================<br>
Comment at: include/llvm/Transforms/<wbr>Scalar/GVNExpression.h:65<br>
+  Expression(unsigned int o = ~2U)<br>
+      : EType(ExpressionTypeBase), Opcode(o) {}<br>
+  Expression(ExpressionType etype, unsigned int o = ~2U)<br>
----------------<br>
You could call another ctor here like:<br>
Expression(unsigned int o = ..) : Expression(ExpressionTypeBase)<wbr>, o) {}<br></blockquote><div><br></div><div>Yeah</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<a href="https://reviews.llvm.org/D26224" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D26224</a><br>
<br>
<br>
<br>
</blockquote></div><br></div></div>