<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr">
<p>Hi Michael,<br>
</p>
<p><br>
</p>
<p>Thanks for the info. I had to do this very quickly and I completely forgot about the SVN/git problems and explaining. I will remember next time.</p>
<p><br>
</p>
<p>Regards,</p>
<p>Pablo<br>
</p>
<br>
<div style="color: rgb(0, 0, 0);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Michael Kuperstein <mkuper@google.com><br>
<b>Sent:</b> 15 November 2016 18:47<br>
<b>To:</b> Pablo Barrio<br>
<b>Cc:</b> llvm-commits<br>
<b>Subject:</b> Re: [llvm] r286975 - Revert "[JumpThreading] Prevent non-deterministic use lists"</font>
<div> </div>
</div>
<div>
<div dir="ltr">Hi Pablo,
<div><br>
<div>Next time you revert a commit, could you please:</div>
<div>1) Include the SVN revision number of the reverted commit (at least until we move to github :-) )</div>
<div>2) Explain why you're reverting. This makes the commit/revert/reapply/revert/reapply dance that sometimes, unfortunately, happens a lot easier to track.</div>
<div><br>
</div>
<div>Thanks,</div>
<div> Michael</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Nov 15, 2016 at 7:42 AM, Pablo Barrio via llvm-commits
<span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
Author: pabbar01<br>
Date: Tue Nov 15 09:42:17 2016<br>
New Revision: 286975<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=286975&view=rev" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project?rev=286975&view=rev</a><br>
Log:<br>
Revert "[JumpThreading] Prevent non-deterministic use lists"<br>
<br>
This reverts commit f2c2f5354070469dac253373c66527<wbr>ca971ddc66.<br>
<br>
Modified:<br>
llvm/trunk/lib/Transforms/<wbr>Scalar/JumpThreading.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/JumpThreading.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp?rev=286975&r1=286974&r2=286975&view=diff" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/<wbr>JumpThreading.cpp?rev=286975&<wbr>r1=286974&r2=286975&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/<wbr>Scalar/JumpThreading.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/<wbr>Scalar/JumpThreading.cpp Tue Nov 15 09:42:17 2016<br>
@@ -2042,18 +2042,19 @@ bool JumpThreadingPass::<wbr>TryToUnfoldSelec<br>
// Look for scalar booleans used in selects as conditions. If there are<br>
// several selects that use the same boolean, they are candidates for jump<br>
// threading and therefore we should unfold them.<br>
- for (Use& U : I.uses()) {<br>
- auto *SI = dyn_cast<SelectInst>(U.<wbr>getUser());<br>
- if (SI && U.getOperandNo() == 0)<br>
+ for (Value *U : I.users())<br>
+ if (auto *SI = dyn_cast<SelectInst>(U))<br>
Selects.push_back(SI);<br>
- }<br>
-<br>
if (Selects.size() <= 1)<br>
continue;<br>
<br>
+ // Remove duplicates<br>
+ std::sort(Selects.begin(), Selects.end());<br>
+ auto NewEnd = std::unique(Selects.begin(), Selects.end());<br>
+<br>
Changed = true;<br>
- for (auto SI : Selects)<br>
- expandSelect(SI);<br>
+ for (auto SI = Selects.begin(); SI != NewEnd; ++SI)<br>
+ expandSelect(*SI);<br>
}<br>
}<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>