<div dir="ltr">Can you try to run your benchmark again without --build-id? For me, this patch slows down the linker by about 30% with --threads and without --build-id.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 15, 2016 at 2:13 PM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Tue Nov 15 16:13:16 2016<br>
New Revision: 287042<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=287042&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=287042&view=rev</a><br>
Log:<br>
Use one task per iteration in parallel_for_loop.<br>
<br>
This seems far more natural. A user can create larger chunks if the<br>
overhead is too large.<br>
<br>
With this linking xul with "--threads --build-id=sha1 goes from<br>
13.938177535 to 11.035953538 seconds on linux.<br>
<br>
Modified:<br>
    lld/trunk/include/lld/Core/<wbr>Parallel.h<br>
<br>
Modified: lld/trunk/include/lld/Core/<wbr>Parallel.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Parallel.h?rev=287042&r1=287041&r2=287042&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/include/lld/<wbr>Core/Parallel.h?rev=287042&r1=<wbr>287041&r2=287042&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/include/lld/Core/<wbr>Parallel.h (original)<br>
+++ lld/trunk/include/lld/Core/<wbr>Parallel.h Tue Nov 15 16:13:16 2016<br>
@@ -284,12 +284,8 @@ void parallel_for_each(Iterator begin, I<br>
 template <class Iterator, class Func><br>
 void parallel_for_each(Iterator begin, Iterator end, Func func) {<br>
   TaskGroup tg;<br>
-  ptrdiff_t taskSize = 1024;<br>
-  while (taskSize <= std::distance(begin, end)) {<br>
-    tg.spawn([=, &func] { std::for_each(begin, begin + taskSize, func); });<br>
-    begin += taskSize;<br>
-  }<br>
-  std::for_each(begin, end, func);<br>
+  for (; begin != end; ++begin)<br>
+    tg.spawn([=, &func] { func(*begin); });<br>
 }<br>
 #endif<br>
 } // end namespace lld<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>