<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sun, Nov 13, 2016 at 8:00 PM Vedant Kumar <<a href="mailto:vsk@apple.com">vsk@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsk added a subscriber: jordan_rose.<br class="gmail_msg">
vsk added a comment.<br class="gmail_msg">
<br class="gmail_msg">
Hm, this doesn't seem workable. Deleting these constructors would make it harder to pass strings into functions.<br class="gmail_msg">
<br class="gmail_msg">
Maybe it would be better to try something like r286139, and just delete `Twine &operator=(T &&)` when T is a std::string or a StringRef. @jordan_rose wdyt?<br class="gmail_msg"></blockquote><div><br></div><div>Is there any reason Twine supports assignment of any kind? That doesn't seem ideal/intentional, given its design... (but I know there are some cases that use named Twines - so perhaps it's common enough we should continue supporting it, though I'd be /really/ suspicious of such code, it'd be easy to create dangling Twines).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D26568" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26568</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div></div>