<div dir="ltr">Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 14, 2016 at 3:23 PM, Vedant Kumar <span dir="ltr"><<a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">r286904<br>
<div class="HOEnZb"><div class="h5"><br>
> On Nov 14, 2016, at 3:20 PM, Vedant Kumar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Sorry about that, I'll switch it back to xfail just on Darwin.<br>
><br>
> vedant<br>
><br>
>> On Nov 14, 2016, at 3:19 PM, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk">peter@pcc.me.uk</a>> wrote:<br>
>><br>
>> This would seem to disable the tests everywhere when we want them enabled everywhere except Darwin?<br>
>><br>
>> Peter<br>
>><br>
>> On Mon, Nov 14, 2016 at 2:50 PM, Vedant Kumar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> Author: vedantk<br>
>> Date: Mon Nov 14 16:50:13 2016<br>
>> New Revision: 286902<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=286902&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=286902&view=rev</a><br>
>> Log:<br>
>> [cfi] Mark some tests as requiring additional support from the MachO writer<br>
>><br>
>> These tests need to be marked as unsupported on Darwin:<br>
>><br>
>>  <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/1545" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/clang-stage1-cmake-<wbr>RA-expensive/1545</a><br>
>><br>
>> Modified:<br>
>>    compiler-rt/trunk/test/cfi/<wbr>icall/external-call.c<br>
>>    compiler-rt/trunk/test/cfi/<wbr>icall/weak.c<br>
>><br>
>> Modified: compiler-rt/trunk/test/cfi/<wbr>icall/external-call.c<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/cfi/icall/external-call.c?rev=286902&r1=286901&r2=286902&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/cfi/icall/external-call.<wbr>c?rev=286902&r1=286901&r2=<wbr>286902&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/test/cfi/<wbr>icall/external-call.c (original)<br>
>> +++ compiler-rt/trunk/test/cfi/<wbr>icall/external-call.c Mon Nov 14 16:50:13 2016<br>
>> @@ -4,7 +4,7 @@<br>
>><br>
>> // This test uses jump tables containing PC-relative references to external<br>
>> // symbols, which the Mach-O object writer does not currently support.<br>
>> -// XFAIL: darwin<br>
>> +// REQUIRES: rdar://problem/29255437<br>
>><br>
>> #include <stdlib.h><br>
>> #include <stdio.h><br>
>><br>
>> Modified: compiler-rt/trunk/test/cfi/<wbr>icall/weak.c<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/cfi/icall/weak.c?rev=286902&r1=286901&r2=286902&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/cfi/icall/weak.c?rev=<wbr>286902&r1=286901&r2=286902&<wbr>view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/test/cfi/<wbr>icall/weak.c (original)<br>
>> +++ compiler-rt/trunk/test/cfi/<wbr>icall/weak.c Mon Nov 14 16:50:13 2016<br>
>> @@ -1,5 +1,6 @@<br>
>> // Test that weak symbols stay weak.<br>
>> // RUN: %clang_cfi -lm -o %t1 %s && %t1<br>
>> +// REQUIRES: rdar://problem/29255437<br>
>><br>
>> __attribute__((weak)) void does_not_exist(void);<br>
>><br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> --<br>
>> Peter<br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>